From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonatan Schlag To: development@lists.ipfire.org Subject: [PATCH v2 18/18] initscripts fkt: Check that readhash returns 1 on a missing file Date: Sun, 16 Jun 2024 18:02:45 +0200 Message-ID: <20240616160245.18865-19-jonatan.schlag@ipfire.org> In-Reply-To: <20240616160245.18865-1-jonatan.schlag@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0001540080892346616==" List-Id: --===============0001540080892346616== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It already does that, so the function is not changed Signed-off-by: Jonatan Schlag --- tests/src/initscripts/system/functions/test.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/src/initscripts/system/functions/test.sh b/tests/src/inits= cripts/system/functions/test.sh index e7f695f55..dbcbd45ef 100755 --- a/tests/src/initscripts/system/functions/test.sh +++ b/tests/src/initscripts/system/functions/test.sh @@ -10,6 +10,7 @@ ROOT=3D"$(readlink -f "${SCRIPT_PATH}/../../../../..")" =20 # read the date in readhash "CONFIG" "${SCRIPT_PATH}/data/1" +test_command [ $? =3D=3D 0 ] =20 # test if we read the correct data test_value_in_array "CONFIG" "RED_DHCP_HOSTNAME" "ipfire" @@ -27,6 +28,8 @@ test_that_output_is "${SCRIPT_PATH}/data/1_output_stderr" "= 2" readhash "CONFIG" =20 # Check with invalid Lines (values and keys) readhash "CONFIG2" "${SCRIPT_PATH}/data/2" &> /dev/null +test_command [ $? =3D=3D 0 ] + =20 # test if we read the correct data test_value_in_array "CONFIG2" "RED_DHCP_HOSTNAME" "ipfire" @@ -39,4 +42,6 @@ test_value_in_array "CONFIG2" "BLUE_MACADDR" "bc:30:7d:58:6= b:e3" test_that_output_is "${SCRIPT_PATH}/data/2_output_stdout" "1" readhash "CONF= IG2" "${SCRIPT_PATH}/data/2" test_that_output_is "${SCRIPT_PATH}/data/2_output_stderr" "2" readhash "CONF= IG2" "${SCRIPT_PATH}/data/2" =20 - +# Check non existent file +readhash "CONFIG3" "${SCRIPT_PATH}/data/-1" &> /dev/null +test_command [ $? =3D=3D 1 ] --=20 2.39.2 --===============0001540080892346616==--