From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH v2 03/18] tests/lib.sh: Add check if variable exists to
 test_value_in_array
Date: Sun, 16 Jun 2024 18:02:30 +0200
Message-ID: <20240616160245.18865-4-jonatan.schlag@ipfire.org>
In-Reply-To: <20240616160245.18865-1-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8225888659194685430=="
List-Id: <development.lists.ipfire.org>

--===============8225888659194685430==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

We cannot use [ -v ] here as this does not work. We need to check if the
array is correctly declared.

Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
 tests/lib.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/lib.sh b/tests/lib.sh
index 716922024..4fce151f8 100644
--- a/tests/lib.sh
+++ b/tests/lib.sh
@@ -28,9 +28,18 @@ var_has_value() {
=20
 test_value_in_array() {
 	local -n array=3D"${1}"
+	local arrayname=3D"${1}"
 	local key=3D"${2}"
 	local value=3D"${3}"
=20
+	# `declare -p` print out how the variable with the name $arrayname was decl=
ared
+	# If the array was not declared as indexed or associative array we fail. We=
 cannot check for a value in an array if=20
+	# we were not given array.
+	if [[ ! "$(declare  -p "${arrayname}")" =3D~ "declare -a" && ! "$(declare  =
-p "${arrayname}")" =3D~ "declare -A" ]]; then
+		echo -e "${CLR_RED_BG}Test failed: The array '${1}' does not exists. The v=
ariable is not set.${CLR_RESET}'"
+		return 1
+	fi
+
 	if [[ "${array[${key}]}" =3D=3D "${value}" ]] ; then
 		echo -e "${CLR_GREEN_BG}Test succeded: The array '${1}' contains the value=
 '${value}' under the key '${key}' ${CLR_RESET}"
 		return 0
--=20
2.39.2


--===============8225888659194685430==--