From: Stephen Cuka <stephen@firemypi.org>
To: development@lists.ipfire.org
Subject: [PATCH] Remove space after every 80 characters in WebGUI "Logs/System Logs".
Date: Sat, 03 Aug 2024 16:36:27 -0600 [thread overview]
Message-ID: <20240803223627.123287-1-stephen@firemypi.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
Signed-off-by: Stephen Cuka <stephen(a)firemypi.org>
---
This patch addresses an issue with the IPFire WebGUI adding a space
after every 80 characters in the display of long log entries on the
"Logs/System Logs" page. (Bug 13735)
The patch removes the "very basic breaking of lines..." code and replaces it
with a direct copy of the log entry $data to the display output variable $d.
html/cgi-bin/logs.cgi/log.dat | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/html/cgi-bin/logs.cgi/log.dat b/html/cgi-bin/logs.cgi/log.dat
index 01c382a0d..ce7de0178 100644
--- a/html/cgi-bin/logs.cgi/log.dat
+++ b/html/cgi-bin/logs.cgi/log.dat
@@ -412,11 +412,12 @@ foreach $_ (@log)
$sec = 'kernel';
$data = $2.': '.$data;
}
- my $d = substr ($data,0,80);
- while (length($data)>80){ #very basic breaking of lines...
- $data = substr ($data,80); #permit correct display in table cell
- $d .= ' ' . substr ($data,0,80);
- }
+ #my $d = substr ($data,0,80);
+ #while (length($data)>80){ #very basic breaking of lines...
+ # $data = substr ($data,80); #permit correct display in table cell
+ # $d .= ' ' . substr ($data,0,80);
+ #}
+ my $d = $data; #don't break lines for display
my $col="";
if ($lines % 2) {
--
2.34.1
next reply other threads:[~2024-08-03 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 22:36 Stephen Cuka [this message]
2024-08-04 10:50 ` Bernhard Bitsch
2024-08-05 8:01 ` Adolf Belka
2024-08-05 18:47 ` Stephen Cuka
2024-08-05 20:40 ` Adolf Belka
2024-08-06 15:59 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240803223627.123287-1-stephen@firemypi.org \
--to=stephen@firemypi.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox