From: Robin Roevens <robin.roevens@disroot.org>
To: development@lists.ipfire.org
Subject: [PATCH] header.pl: only get memory consumption when service is running
Date: Tue, 10 Sep 2024 23:32:32 +0200 [thread overview]
Message-ID: <20240910213232.1695033-1-robin.roevens@disroot.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
It probably doesn't matter much as the get_memory_consumption function just returns 0 when no pids are found. But it shouldn't even try as the mem var is never used when the service is not running.
---
| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
index a90a6f481..3778c4e59 100644
--- a/config/cfgroot/header.pl
+++ b/config/cfgroot/header.pl
@@ -950,9 +950,6 @@ EOF
@pids = &General::find_pids("${process}");
}
- # Get memory consumption
- my $mem = &General::get_memory_consumption(@pids);
-
print <<EOF;
<tr>
<th scope="row">
@@ -962,6 +959,9 @@ EOF
# Running?
if (scalar @pids) {
+ # Get memory consumption
+ my $mem = &General::get_memory_consumption(@pids);
+
# Format memory
$mem = &General::formatBytes($mem);
--
2.46.0
reply other threads:[~2024-09-10 21:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910213232.1695033-1-robin.roevens@disroot.org \
--to=robin.roevens@disroot.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox