From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 1/2] transmission: Update to version 4.0.6 Date: Tue, 24 Sep 2024 11:43:00 +0200 Message-ID: <20240924094301.2130-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5622767824075953567==" List-Id: --===============5622767824075953567== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable - Update from version 4.0.5 to 4.0.6 - Update of rootfile not required - Bundled miniupnpc not working with build of 4.0.6 As we prefer not to use b= undled packages where possible, this patch set builds miniupnpc prior to transmis= sion. As miniupnpc is only required for the build of transmission, nothing is insta= lled from miniupnpc. - miniupnpc-2.2.8 has a problem with transmission and needs a patch to fix it= . Added into the transmission lfs file - Changelog 4.0.6 All Platforms Improved parsing HTTP tracker announce response. (#6223) Fixed 4.0.0 bug that caused some user scripts to have an invalid TR_TORR= ENT_TRACKERS environment variable. (#6434) Fixed 4.0.0 bug where alt-speed-enabled had no effect in settings.json. = (#6483) Fixed 4.0.0 bug where the GTK client's "Use authentication" option was n= ot saved between's sessions. (#6514) Fixed 4.0.0 bug where the filename for single-file torrents aren't sanit= ized. (#6846) macOS Client Fix: Sparkle support for handling beta version updates. (#5263) Fixed app unable to start when having many torrents and TimeMachine enab= led. (#6523) Fix: Sparkle Version Comparator. (#6623) Qt Client Fixed 4.0.0 bug where piece size description text and slider state in to= rrent creation dialog are not always up-to-date. (#6516) GTK Client Fixed build when compiling with GTKMM 4. (#6393) Added developer name to metainfo files. (#6598) Added the launchable desktop-id to metainfo files. (#6779) Fixed build when compiling on BSD. (#6812) Web Client Fixed a 4.0.0 bug where the infinite ratio symbol was displayed incorrec= tly in the WebUI. (#6491, #6500) Fixed layout issue in speed display. (#6570) General UI improvement related to filterbar and fixes download/upload sp= eed info wrap. (#6761) Daemon Fixed a couple of logging issues. (#6463) Everything Else Updated flatpak release metainfo. (#6357) Fixed libtransmission build on very old cmake versions. (#6418) UTP peer connections follow user-defined speed limits better now. (#6551) Only use a single concurrent queue for timeMachineExclude instead of one= queue per torrent (#6523). (#6558) Fixed 4.0.5 bug where svg and png icons in the WebUI might not be displa= yed. (#6563) Fixed 4.0.0 bug where alt-speed-enabled had no effect in settings.json. = (#6564) Fixed 4.0.0 bugs where some RPC methods don't put torrents in recently-a= ctive anymore. (#6565) Improved parsing HTTP tracker announce response. (#6567) Fixed compatibility with clang-format 18. (#6690) Fixed build when compiling with mbedtls 3.x . (#6823) Signed-off-by: Adolf Belka --- lfs/transmission | 7 ++-- ...ission-4.0.6-fix_for_miniupnpc-2.2.8.patch | 34 +++++++++++++++++++ 2 files changed, 38 insertions(+), 3 deletions(-) create mode 100644 src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.pa= tch diff --git a/lfs/transmission b/lfs/transmission index 298c2a0e9..1568b67e7 100644 --- a/lfs/transmission +++ b/lfs/transmission @@ -26,7 +26,7 @@ include Config =20 SUMMARY =3D A BitTorrent client with multiple UIs =20 -VER =3D 4.0.5 +VER =3D 4.0.6 =20 THISAPP =3D transmission-$(VER) DL_FILE =3D $(THISAPP).tar.xz @@ -34,7 +34,7 @@ DL_FROM =3D $(URL_IPFIRE) DIR_APP =3D $(DIR_SRC)/$(THISAPP) TARGET =3D $(DIR_INFO)/$(THISAPP) PROG =3D transmission -PAK_VER =3D 22 +PAK_VER =3D 23 =20 DEPS =3D =20 @@ -48,7 +48,7 @@ objects =3D $(DL_FILE) =20 $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) =20 -$(DL_FILE)_BLAKE2 =3D 60caa3bc615137b225d3ac3f25daa352c6960fcc848c91e5ea4548= 8ae109d93b53e314e4683bd7c4ef3f9b2f364d796b6c5bb014ca647d3f44fb5c9df9f8c997 +$(DL_FILE)_BLAKE2 =3D 3eb1d851322299cb1b79c799f431c09db5aee1be0372fa2877e165= 08ca6f9e78ea42ed75520ab29a3325e62efcfca63a83559db73c39c981c9e2eddb403ef65a =20 install : $(TARGET) =20 @@ -81,6 +81,7 @@ $(subst %,%_BLAKE2,$(objects)) : $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) @$(PREBUILD) @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) + cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/transmission-4.0.6-fi= x_for_miniupnpc-2.2.8.patch cd $(DIR_APP) && cmake . \ -DCMAKE_INSTALL_PREFIX=3D/usr \ -DCMAKE_BUILD_TYPE=3DRelease \ diff --git a/src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch b/s= rc/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch new file mode 100644 index 000000000..3426d13bc --- /dev/null +++ b/src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch @@ -0,0 +1,34 @@ +From febfe49ca3ecab1a7142ecb34012c1f0b2bcdee8 Mon Sep 17 00:00:00 2001 +From: =3D?UTF-8?q?C=3DC5=3D93ur?=3D +Date: Sat, 15 Jun 2024 07:24:06 +0800 +Subject: [PATCH] bump miniupnpc to 2.2.8 (#6907) + +* bump miniupnpc to 2.2.8 + +* Avoid build error "ln: include/miniupnpc/.: Operation not permitted" +--- + Transmission.xcodeproj/project.pbxproj | 2 +- + libtransmission/port-forwarding-upnp.cc | 9 +++++++-- + third-party/miniupnp | 2 +- + 3 files changed, 9 insertions(+), 4 deletions(-) + +diff --git a/libtransmission/port-forwarding-upnp.cc b/libtransmission/port-= forwarding-upnp.cc +index 6d7bbc7f7c2..a4146e0df13 100644 +--- a/libtransmission/port-forwarding-upnp.cc ++++ b/libtransmission/port-forwarding-upnp.cc +@@ -261,8 +261,13 @@ tr_port_forwarding_state tr_upnpPulse( +=20 + FreeUPNPUrls(&handle->urls); + auto lanaddr =3D std::array{}; +- if (UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::da= ta(lanaddr), std::size(lanaddr) - 1) =3D=3D +- UPNP_IGD_VALID_CONNECTED) ++ if ( ++#if (MINIUPNPC_API_VERSION >=3D 18) ++ UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::da= ta(lanaddr), std::size(lanaddr) - 1, nullptr, 0) ++#else ++ UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::da= ta(lanaddr), std::size(lanaddr) - 1) ++#endif ++ =3D=3D UPNP_IGD_VALID_CONNECTED) + { + tr_logAddInfo(fmt::format(_("Found Internet Gateway Device '{ur= l}'"), fmt::arg("url", handle->urls.controlURL))); + tr_logAddInfo(fmt::format(_("Local Address is '{address}'"), fm= t::arg("address", lanaddr.data()))); --=20 2.46.0 --===============5622767824075953567==--