From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: [PATCH 2/4] connections.cgi: Ignore empty interfaces Date: Fri, 06 Dec 2024 16:44:15 +0000 Message-ID: <20241206164417.3840426-2-michael.tremer@ipfire.org> In-Reply-To: <20241206164417.3840426-1-michael.tremer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3747296254728369376==" List-Id: --===============3747296254728369376== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Parsing any custom routes for any custom interfaces was broken so that arbitrary routes were imported when not all interfaces were in use. Signed-off-by: Michael Tremer --- html/cgi-bin/connections.cgi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/html/cgi-bin/connections.cgi b/html/cgi-bin/connections.cgi index af375effe..705118576 100644 --- a/html/cgi-bin/connections.cgi +++ b/html/cgi-bin/connections.cgi @@ -89,6 +89,9 @@ my @routes = &General::system_output("ip", "route", "show"); # Find all routes foreach my $intf (keys %interfaces) { + # Skip empty interfaces + next if ($intf eq ""); + foreach my $route (grep(/dev ${intf}/, @routes)) { if ($route =~ m/^(\d+\.\d+\.\d+\.\d+\/\d+)/) { $networks{$1} = $interfaces{$intf}; -- 2.39.5 --===============3747296254728369376==--