[PATCH] Add button spacing on 'Firewall/Firewall Groups' page.

public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed

* [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
@ 2025-03-02  9:26 Stephen Cuka
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Cuka @ 2025-03-02  9:26 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]

Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.

No changes to the functions of the page.
---
 html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
index d6be6c40e..d29940b8d 100644
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -1320,10 +1320,29 @@ sub showmenu {
 	&Header::openbox('100%', 'left',);
 	print "$Lang::tr{'fwhost welcome'}";
 	print<<END;
-	<br><br><table border='0' width='100%'>
-	<tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
-	<td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
-	<tr><td colspan='6'></td></tr></table>
+	<br><br>
+	<table border='0' width='100%'>
+		<tr>
+			<td>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
+			</form>
+			</td>
+			<td align='right'>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
+			</form>
+			</td>
+		</tr>
+		<tr>
+			<td colspan='6'>
+			</td>
+		</tr>
+	</table>
 END
 	&Header::closebox();
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
@ 2025-03-02  9:26 Stephen Cuka
  2025-03-05 11:56 ` Michael Tremer
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Cuka @ 2025-03-02  9:26 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]

Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.

No changes to the functions of the page.

Signed-off-by: Stephen Cuka <stephen(a)firemypi.org>
---
 html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
index d6be6c40e..d29940b8d 100644
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -1320,10 +1320,29 @@ sub showmenu {
 	&Header::openbox('100%', 'left',);
 	print "$Lang::tr{'fwhost welcome'}";
 	print<<END;
-	<br><br><table border='0' width='100%'>
-	<tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
-	<td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
-	<tr><td colspan='6'></td></tr></table>
+	<br><br>
+	<table border='0' width='100%'>
+		<tr>
+			<td>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
+			</form>
+			</td>
+			<td align='right'>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
+			</form>
+			</td>
+		</tr>
+		<tr>
+			<td colspan='6'>
+			</td>
+		</tr>
+	</table>
 END
 	&Header::closebox();
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
  2025-03-02  9:26 Stephen Cuka
@ 2025-03-05 11:56 ` Michael Tremer
       [not found]   ` <82aba8d9-5fa2-4ece-bec0-b1068ac10fc8@firemypi.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Tremer @ 2025-03-05 11:56 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

Hello Stephen,

Thank you for the patch. I am seeing three emails here which all seem to be almost identical?

Was there a problem submitting the patch or are there actually any changes here which I have missed?

-Michael

> On 27 Feb 2025, at 20:43, Stephen Cuka <stephen(a)firemypi.org> wrote:
> 
> Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.
> 
> No changes to the functions of the page.
> 
> Signed-off-by: Stephen Cuka <stephen(a)firemypi.org>
> ---
> html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
> index d6be6c40e..d29940b8d 100644
> --- a/html/cgi-bin/fwhosts.cgi
> +++ b/html/cgi-bin/fwhosts.cgi
> @@ -1320,10 +1320,29 @@ sub showmenu {
> &Header::openbox('100%', 'left',);
> print "$Lang::tr{'fwhost welcome'}";
> print<<END;
> - <br><br><table border='0' width='100%'>
> - <tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
> - <td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
> - <tr><td colspan='6'></td></tr></table>
> + <br><br>
> + <table border='0' width='100%'>
> + <tr>
> + <td>
> + <form method='post'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
> + </form>
> + </td>
> + <td align='right'>
> + <form method='post'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
> + </form>
> + </td>
> + </tr>
> + <tr>
> + <td colspan='6'>
> + </td>
> + </tr>
> + </table>
> END
> &Header::closebox();
> 
> -- 
> 2.43.0
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <82aba8d9-5fa2-4ece-bec0-b1068ac10fc8@firemypi.org>]

* Re: [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
       [not found]   ` <82aba8d9-5fa2-4ece-bec0-b1068ac10fc8@firemypi.org>
@ 2025-03-06 10:40     ` Michael Tremer
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Tremer @ 2025-03-06 10:40 UTC (permalink / raw)
  To: Stephen Cuka; +Cc: development

Hello Stephen,

Apologies, I have been working on the mailing list system and last week, something must have locked up in Mailman as it used to do. Adolf also have a lot of patches stuck in the queue.

This was simply because mailman refused to accept any emails and they got stuck in the Postfix queue.

Emails should usually be showing up in the archive pretty much instantaneously and patchwork sometimes takes an extra ten seconds on so.

I have marked the other patches in patchwork so that they won’t show up any more and we can look at the latest one.

Best,
-Michael

> On 5 Mar 2025, at 15:15, Stephen Cuka <stephen@firemypi.org> wrote:
> 
> Hello Michael,
> 
> I did have a problem submitting the patch.  When I first submitted it, I checked patchworks and did not see it posted there.  I figured that it might take some time so I waited about a day and when it still hadn't posted, resent it.  I waited a while again it still didn't show up.  I was trying to figure out what I had done wrong and  realized that all of the other patch descriptions started with the component name in the description.  So, thinking that maybe that was needed for the patch to be uploaded, added that and resent it.  It still didn't show up so I stopped at that point and checked again, maybe a day later, and saw that all of the emails that I sent had been uploaded at once.  I think it was 3 days later that all of them showed up.  I didn't realize that it would take that long.
> 
> Anyway, the patch with the description starting with "fwhosts.cgi:" is the one to look at.  The others can be deleted or cancelled.
> 
> Regards,
> 
> Stephen
> 
> 
> 
> On 3/5/25 04:56, Michael Tremer wrote:
>> Hello Stephen,
>> 
>> Thank you for the patch. I am seeing three emails here which all seem to be almost identical?
>> 
>> Was there a problem submitting the patch or are there actually any changes here which I have missed?
>> 
>> -Michael
>> 
>>> On 27 Feb 2025, at 20:43, Stephen Cuka <stephen@firemypi.org> wrote:
>>> 
>>> Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.
>>> 
>>> No changes to the functions of the page.
>>> 
>>> Signed-off-by: Stephen Cuka <stephen@firemypi.org>
>>> ---
>>> html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
>>> 1 file changed, 23 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
>>> index d6be6c40e..d29940b8d 100644
>>> --- a/html/cgi-bin/fwhosts.cgi
>>> +++ b/html/cgi-bin/fwhosts.cgi
>>> @@ -1320,10 +1320,29 @@ sub showmenu {
>>> &Header::openbox('100%', 'left',);
>>> print "$Lang::tr{'fwhost welcome'}";
>>> print<<END;
>>> - <br><br><table border='0' width='100%'>
>>> - <tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
>>> - <td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
>>> - <tr><td colspan='6'></td></tr></table>
>>> + <br><br>
>>> + <table border='0' width='100%'>
>>> + <tr>
>>> + <td>
>>> + <form method='post'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
>>> + </form>
>>> + </td>
>>> + <td align='right'>
>>> + <form method='post'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
>>> + <input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
>>> + </form>
>>> + </td>
>>> + </tr>
>>> + <tr>
>>> + <td colspan='6'>
>>> + </td>
>>> + </tr>
>>> + </table>
>>> END
>>> &Header::closebox();
>>> 
>>> -- 
>>> 2.43.0
>>> 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] Add button spacing on 'Firewall/Firewall Groups' page.
@ 2025-03-02  9:26 Stephen Cuka
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Cuka @ 2025-03-02  9:26 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]

Add spacing between showmenu() buttons on Firewall/Firewall Groups page to improve the look of the page.

No changes to the functions of the page.

Signed-off-by: Stephen Cuka <stephen(a)firemypi.org>
---
 html/cgi-bin/fwhosts.cgi | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)
 mode change 100644 => 100755 html/cgi-bin/fwhosts.cgi

diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
old mode 100644
new mode 100755
index d6be6c40e..d29940b8d
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -1320,10 +1320,29 @@ sub showmenu {
 	&Header::openbox('100%', 'left',);
 	print "$Lang::tr{'fwhost welcome'}";
 	print<<END;
-	<br><br><table border='0' width='100%'>
-	<tr><td><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}' ></form></td>
-	<td align='right'><form method='post'><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}' ><input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}' ></form></td></tr>
-	<tr><td colspan='6'></td></tr></table>
+	<br><br>
+	<table border='0' width='100%'>
+		<tr>
+			<td>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newnet'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newhost'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newgrp'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newlocationgrp'}'>
+			</form>
+			</td>
+			<td align='right'>
+			<form method='post'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservice'}'>
+			<input type='submit' name='ACTION' value='$Lang::tr{'fwhost newservicegrp'}'>
+			</form>
+			</td>
+		</tr>
+		<tr>
+			<td colspan='6'>
+			</td>
+		</tr>
+	</table>
 END
 	&Header::closebox();
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-03-06 10:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-02  9:26 [PATCH] Add button spacing on 'Firewall/Firewall Groups' page Stephen Cuka
  -- strict thread matches above, loose matches on Subject: below --
2025-03-02  9:26 Stephen Cuka
2025-03-05 11:56 ` Michael Tremer
     [not found]   ` <82aba8d9-5fa2-4ece-bec0-b1068ac10fc8@firemypi.org>
2025-03-06 10:40     ` Michael Tremer
2025-03-02  9:26 Stephen Cuka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox