public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Cc: Adolf Belka <adolf.belka@ipfire.org>
Subject: [PATCH v2] setup: v2 Fixes bug10245 - removal of so called non-local network stop
Date: Thu, 19 Jun 2025 18:04:18 +0200	[thread overview]
Message-ID: <20250619160418.2398881-1-adolf.belka@ipfire.org> (raw)

- In the setup menu if the OK button is pressed when it asks if you want to change any
   of the interfaces then the red, blue and orange interfaces are stopped. However if
   none of the interfaces are changed then the network restart code does not get used.
- This results in the system ending up with only the green interfrace being UP and
   connected.
- This patch removes the command that stops the red, blue & orange interfaces but leaves
   the green one running. It seems to not bhe needed and if the OK button is pressed
   on the Drivers and card assignments window but no change made then the IPFire system
   is left with only the green interface connected.
- This command has been present since at least Core Update 30 and the bug was originally
   raised in 2012.
- I tested out this v2 code on my vm testbed and everything worked fine and if any
   change was made then when leaving the Networking section the Network and Unbound were
   restarted.

Fixes: bug10245
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 src/setup/networking.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/setup/networking.c b/src/setup/networking.c
index 8d398f365..98018b7f6 100644
--- a/src/setup/networking.c
+++ b/src/setup/networking.c
@@ -420,9 +420,6 @@ int changedrivers(void)
 		errorbox(_("Unable to open settings file"));
 		return 0;
 	}
-	if (automode == 0)
-		runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange",
-			_("Networking"), _("Restarting non-local network..."), NULL);
 
 	findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp);
 	if (configtype == 1)
-- 
2.49.0



                 reply	other threads:[~2025-06-19 16:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250619160418.2398881-1-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox