From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bNQQx6cH3z2xRj for ; Thu, 19 Jun 2025 16:04:25 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bNQQt33Rvz2xMP for ; Thu, 19 Jun 2025 16:04:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4bNQQs1521zTd; Thu, 19 Jun 2025 16:04:21 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1750349061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8TuftdrsN4J1FdLM4goSYAps1/Be8asYkiOwCRHFXtE=; b=8IYmRMx4p/SlkulG68malPaDUpjCabWH3fWoh4SxXUCiT3Y/Tdh7/NSXK1SYcgCHhgqjEH 3sV5p91L5/SY+XAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1750349061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8TuftdrsN4J1FdLM4goSYAps1/Be8asYkiOwCRHFXtE=; b=keeFYwqr31X7ayGWHF9ADyP0zh00n6w4fOny32yYTPHKYXgmdLo2qrFYLBMLUNYwC7/Wz6 VJOeL1quN6bSb/yJLikOWl8HC6eEkwCPEK56jvrNjnmlS0HyaO8WBZ6+TXEiawUB5ugozX jBHAuH/e8CHvovBiwsW3tcv4sRm/55gtvyOhsZiSIG95GqnPdPwYfgy1HQZLDimheDIkUS UZttZAH3N1XllkX5KtvRNLtcagIPEYChHr0ph7pgwVTJlA60W+PIxt3iJCvPp4QLKqJA0p HFSt+GLcGCtrKBqgOPpxszefj2+W+zY0oSz7CPbLwYJiLKH4mFKrpX/QGXYDLQ== From: Adolf Belka To: development@lists.ipfire.org Cc: Adolf Belka Subject: [PATCH v2] setup: v2 Fixes bug10245 - removal of so called non-local network stop Date: Thu, 19 Jun 2025 18:04:18 +0200 Message-ID: <20250619160418.2398881-1-adolf.belka@ipfire.org> Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit - In the setup menu if the OK button is pressed when it asks if you want to change any of the interfaces then the red, blue and orange interfaces are stopped. However if none of the interfaces are changed then the network restart code does not get used. - This results in the system ending up with only the green interfrace being UP and connected. - This patch removes the command that stops the red, blue & orange interfaces but leaves the green one running. It seems to not bhe needed and if the OK button is pressed on the Drivers and card assignments window but no change made then the IPFire system is left with only the green interface connected. - This command has been present since at least Core Update 30 and the bug was originally raised in 2012. - I tested out this v2 code on my vm testbed and everything worked fine and if any change was made then when leaving the Networking section the Network and Unbound were restarted. Fixes: bug10245 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/setup/networking.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/setup/networking.c b/src/setup/networking.c index 8d398f365..98018b7f6 100644 --- a/src/setup/networking.c +++ b/src/setup/networking.c @@ -420,9 +420,6 @@ int changedrivers(void) errorbox(_("Unable to open settings file")); return 0; } - if (automode == 0) - runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange", - _("Networking"), _("Restarting non-local network..."), NULL); findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp); if (configtype == 1) -- 2.49.0