public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Cc: Adolf Belka <adolf.belka@ipfire.org>
Subject: [PATCH] core196: Revert ship of customservices from fwhosts
Date: Tue,  1 Jul 2025 15:44:35 +0200	[thread overview]
Message-ID: <20250701134435.10975-1-adolf.belka@ipfire.org> (raw)

- Shipping the customservices file replaced the existing file on all users systems, which
   resulted in any modificationjs they had made being wiped out.
- Having thought about it further what I shouldn have done is just added the additional
   custom service of "DNS over TLS" to the end of the customservices file during the
   update process using update.sh but that is also not so easy because what number to
   use for the "DNS over TLS" entry will depend  on how many custom services the user
   has created.
- At the least the shipping of the customservices file needs to be reverted. I and others
   can then think about alternative ways to provide that entry to existing files.
- Alternatively we could leave it without doing anything. A fresh install will have the
   "DNS over TLS" entry and upgrades will just leave the existing customservices file
   alone.
- Users can of course recover the file by doing a restore from the backup they have
   created but it is not good to overwrite those sorts of files.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/rootfiles/core/196/filelists/files | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config/rootfiles/core/196/filelists/files b/config/rootfiles/core/196/filelists/files
index 1d83bafb5..8e1fc096d 100644
--- a/config/rootfiles/core/196/filelists/files
+++ b/config/rootfiles/core/196/filelists/files
@@ -11,7 +11,6 @@ srv/web/ipfire/cgi-bin/pakfire.cgi
 srv/web/ipfire/cgi-bin/wireguard.cgi
 usr/sbin/setup
 var/ipfire/backup/bin/backup.pl
-var/ipfire/fwhosts/customservices
 var/ipfire/graphs.pl
 var/ipfire/header.pl
 var/ipfire/ipblocklist-functions.pl
-- 
2.50.0



                 reply	other threads:[~2025-07-01 13:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250701134435.10975-1-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox