From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cXWKq12Hbz331g for ; Thu, 25 Sep 2025 11:13:19 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cXWKl5CGmz2xph for ; Thu, 25 Sep 2025 11:13:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cXWKl34fVz3R4; Thu, 25 Sep 2025 11:13:15 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1758798795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSBAhvuV/QYGxga1zGZnJKaCX73bRDU+5IrAOwV3Ox8=; b=Z0IovG68a5So5Ahe8NhlHSt7zp8ZMwASXdBIUiuHbiC6s2Yn4vyfHae/3SDh1uhDVy4PwZ WX2epxrsn50I/IAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1758798795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSBAhvuV/QYGxga1zGZnJKaCX73bRDU+5IrAOwV3Ox8=; b=dPnkLHUHwi9c39jPwGnobiYoheq+IW/3Ir4NyWKaAjewg7O7BakjcKBFieXPpLPNx/bpsl 3N/wl7NkFa++cwZW3pUZb5aEPcYqfWHQWg63tu8UDZkIJ6h9VBieuYpwpkbcZjGnrqHZZM BHKpawOFCdoKuCfWoGwLHxHxQiu0S0sOAwya4bI6LItqK7spDhmcecIIv0LUwwPa8RL4sN /mcXPQfnYCgLppVk7UmAudqpfI6uabq0V4+XKflm1m3neyeyTikCZzL+ArMrGOp/UXFzv7 eOg6537ZiMGhiCNVj2D+B8NT5XCfZoGD5sbfHyB6YGgj97QiQAM6CpBAb+QrUA== From: Adolf Belka To: development@lists.ipfire.org Cc: Adolf Belka Subject: [PATCH 03/16] ovpnclients.dat: Fixes bug 13879 Date: Thu, 25 Sep 2025 13:12:39 +0200 Message-ID: <20250925111252.11893-3-adolf.belka@ipfire.org> In-Reply-To: <20250925111252.11893-1-adolf.belka@ipfire.org> References: <20250925111252.11893-1-adolf.belka@ipfire.org> Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fixes: bug 13879 - CONNECTION_NAME SQL Injection Signed-off-by: Adolf Belka --- html/cgi-bin/logs.cgi/ovpnclients.dat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/html/cgi-bin/logs.cgi/ovpnclients.dat b/html/cgi-bin/logs.cgi/ovpnclients.dat index 8fbf4f8fa..5e6baef3c 100644 --- a/html/cgi-bin/logs.cgi/ovpnclients.dat +++ b/html/cgi-bin/logs.cgi/ovpnclients.dat @@ -2,7 +2,7 @@ ############################################################################### # # # IPFire.org - A linux based firewall # -# Copyright (C) 2020 IPFire Team # +# Copyright (C) 2020 - 2025 IPFire Team # # # # This program is free software: you can redistribute it and/or modify # # it under the terms of the GNU General Public License as published by # @@ -141,7 +141,7 @@ my $database_query = qq( ORDER BY common_name, duration DESC; ); -if ($cgiparams{'CONNECTION_NAME'}) { +if (($cgiparams{'CONNECTION_NAME'}) && ($cgiparams{'CONNECTION_NAME'} =~ /^[a-zA-Z0-9]+$/)) { $database_query = qq( SELECT common_name, DATETIME(connected_at, 'localtime'), DATETIME(disconnected_at, 'localtime'), bytes_received, bytes_sent, STRFTIME('%s', DATETIME(disconnected_at)) - STRFTIME('%s', DATETIME(connected_at)) AS duration FROM sessions -- 2.51.0