[PATCH 1/2] cgi-bin: Apply consistent disable status to debug modules

public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed

* [PATCH 1/2] cgi-bin: Apply consistent disable status to debug modules
@ 2025-10-13 11:15 Adolf Belka
  2025-10-13 11:15 ` [PATCH 2/2] core199: Ship modified cgi files Adolf Belka
  0 siblings, 1 reply; 4+ messages in thread
From: Adolf Belka @ 2025-10-13 11:15 UTC (permalink / raw)
  To: development; +Cc: Adolf Belka

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/connections.cgi    | 8 ++++----
 html/cgi-bin/fireinfo.cgi       | 8 ++++----
 html/cgi-bin/fwhosts.cgi        | 4 ++--
 html/cgi-bin/iptables.cgi       | 3 ++-
 html/cgi-bin/modem-status.cgi   | 8 ++++----
 html/cgi-bin/wirelessclient.cgi | 8 ++++----
 6 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/html/cgi-bin/connections.cgi b/html/cgi-bin/connections.cgi
index 80cb4bb69..0c1282a92 100644
--- a/html/cgi-bin/connections.cgi
+++ b/html/cgi-bin/connections.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2023  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -22,9 +22,9 @@
 use strict;
 use Switch;
 
-# enable only the following on debugging purpose
-use warnings;
-use CGI::Carp 'fatalsToBrowser';
+# only enable the following for debugging purposes
+#use warnings;
+#use CGI::Carp 'fatalsToBrowser';
 
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
diff --git a/html/cgi-bin/fireinfo.cgi b/html/cgi-bin/fireinfo.cgi
index 04e36faf4..33d2f8a88 100644
--- a/html/cgi-bin/fireinfo.cgi
+++ b/html/cgi-bin/fireinfo.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2011  IPFire Team  <info@ipfire.org>                          #
+# Copyright (C) 2011-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -21,9 +21,9 @@
 
 use strict;
 
-# enable only the following on debugging purpose
-use warnings;
-use CGI::Carp 'fatalsToBrowser';
+# only enable the following for debugging purposes
+#use warnings;
+#use CGI::Carp 'fatalsToBrowser';
 
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
index dca425b69..7820523c5 100644
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -20,11 +20,11 @@
 ###############################################################################
 use strict;
 
-# enable only the following on debugging purpose
+# only enable the following for debugging purposes
 #use warnings;
+#use CGI::Carp 'fatalsToBrowser';
 
 use Sort::Naturally;
-use CGI::Carp 'fatalsToBrowser';
 no warnings 'uninitialized';
 require '/var/ipfire/general-functions.pl';
 require '/var/ipfire/network-functions.pl';
diff --git a/html/cgi-bin/iptables.cgi b/html/cgi-bin/iptables.cgi
index a27d6a920..de519a1de 100644
--- a/html/cgi-bin/iptables.cgi
+++ b/html/cgi-bin/iptables.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2010  IPFire Team                                             #
+# Copyright (C) 2010-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -23,6 +23,7 @@ require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
 require "${General::swroot}/header.pl";
 
+# only enable the following for debugging purposes
 #use warnings;
 #use CGI::Carp 'fatalsToBrowser';
 
diff --git a/html/cgi-bin/modem-status.cgi b/html/cgi-bin/modem-status.cgi
index 2d33a3d5e..923780319 100644
--- a/html/cgi-bin/modem-status.cgi
+++ b/html/cgi-bin/modem-status.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2014  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -21,9 +21,9 @@
 
 use strict;
 
-# enable only the following on debugging purpose
-use warnings;
-use CGI::Carp 'fatalsToBrowser';
+# only enable the following for debugging purposes
+#use warnings;
+#use CGI::Carp 'fatalsToBrowser';
 
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient.cgi
index 19c5bea50..6a2ee906a 100644
--- a/html/cgi-bin/wirelessclient.cgi
+++ b/html/cgi-bin/wirelessclient.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2012  IPFire Team  <info@ipfire.org>                          #
+# Copyright (C) 2012-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -24,9 +24,9 @@
 
 use strict;
 
-# enable only the following on debugging purpose
-use warnings;
-use CGI::Carp 'fatalsToBrowser';
+# only enable the following for debugging purposes
+#use warnings;
+#use CGI::Carp 'fatalsToBrowser';
 
 require '/var/ipfire/general-functions.pl';
 require "${General::swroot}/lang.pl";
-- 
2.51.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] core199: Ship modified cgi files
  2025-10-13 11:15 [PATCH 1/2] cgi-bin: Apply consistent disable status to debug modules Adolf Belka
@ 2025-10-13 11:15 ` Adolf Belka
  2025-10-13 15:48   ` Michael Tremer
  0 siblings, 1 reply; 4+ messages in thread
From: Adolf Belka @ 2025-10-13 11:15 UTC (permalink / raw)
  To: development; +Cc: Adolf Belka

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/rootfiles/core/199/filelists/files | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/config/rootfiles/core/199/filelists/files b/config/rootfiles/core/199/filelists/files
index d1dcfade3..e632e77fd 100644
--- a/config/rootfiles/core/199/filelists/files
+++ b/config/rootfiles/core/199/filelists/files
@@ -5,6 +5,12 @@ etc/rc.d/init.d/openvpn-rw
 etc/rc.d/init.d/wireguard
 etc/ssh/ssh_config
 etc/ssh/sshd_config
+srv/web/ipfire/cgi-bin/connections.cgi
+srv/web/ipfire/cgi-bin/fireinfo.cgi
+srv/web/ipfire/cgi-bin/fwhosts.cgi
+srv/web/ipfire/cgi-bin/iptables.cgi
+srv/web/ipfire/cgi-bin/modem-status.cgi
 srv/web/ipfire/cgi-bin/vulnerabilities.cgi
+srv/web/ipfire/cgi-bin/wirelessclient.cgi
 usr/sbin/openvpn-authenticator
 var/ipfire/header.pl
-- 
2.51.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] core199: Ship modified cgi files
  2025-10-13 11:15 ` [PATCH 2/2] core199: Ship modified cgi files Adolf Belka
@ 2025-10-13 15:48   ` Michael Tremer
  2025-10-13 16:04     ` Adolf Belka
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Tremer @ 2025-10-13 15:48 UTC (permalink / raw)
  To: Adolf Belka; +Cc: development

Hi,

We should technically not need this because we ship the entire web user interface:

  config/rootfiles/core/199/filelists/web-user-interface

-Michael

> On 13 Oct 2025, at 12:15, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> config/rootfiles/core/199/filelists/files | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/config/rootfiles/core/199/filelists/files b/config/rootfiles/core/199/filelists/files
> index d1dcfade3..e632e77fd 100644
> --- a/config/rootfiles/core/199/filelists/files
> +++ b/config/rootfiles/core/199/filelists/files
> @@ -5,6 +5,12 @@ etc/rc.d/init.d/openvpn-rw
> etc/rc.d/init.d/wireguard
> etc/ssh/ssh_config
> etc/ssh/sshd_config
> +srv/web/ipfire/cgi-bin/connections.cgi
> +srv/web/ipfire/cgi-bin/fireinfo.cgi
> +srv/web/ipfire/cgi-bin/fwhosts.cgi
> +srv/web/ipfire/cgi-bin/iptables.cgi
> +srv/web/ipfire/cgi-bin/modem-status.cgi
> srv/web/ipfire/cgi-bin/vulnerabilities.cgi
> +srv/web/ipfire/cgi-bin/wirelessclient.cgi
> usr/sbin/openvpn-authenticator
> var/ipfire/header.pl
> -- 
> 2.51.0
> 
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] core199: Ship modified cgi files
  2025-10-13 15:48   ` Michael Tremer
@ 2025-10-13 16:04     ` Adolf Belka
  0 siblings, 0 replies; 4+ messages in thread
From: Adolf Belka @ 2025-10-13 16:04 UTC (permalink / raw)
  To: Michael Tremer; +Cc: development

Hi Michael,

On 13/10/2025 17:48, Michael Tremer wrote:
> Hi,
> 
> We should technically not need this because we ship the entire web user interface:
> 
>    config/rootfiles/core/199/filelists/web-user-interface

That explains it. I did wonder how the various cgi changes had gotten into the update but I decided it was better to be safe than sorry. Now I understand. The web-user-interface package covers everything.

Learn something new each day.

Regards,

Adolf.

> 
> -Michael
> 
>> On 13 Oct 2025, at 12:15, Adolf Belka <adolf.belka@ipfire.org> wrote:
>>
>> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
>> ---
>> config/rootfiles/core/199/filelists/files | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/config/rootfiles/core/199/filelists/files b/config/rootfiles/core/199/filelists/files
>> index d1dcfade3..e632e77fd 100644
>> --- a/config/rootfiles/core/199/filelists/files
>> +++ b/config/rootfiles/core/199/filelists/files
>> @@ -5,6 +5,12 @@ etc/rc.d/init.d/openvpn-rw
>> etc/rc.d/init.d/wireguard
>> etc/ssh/ssh_config
>> etc/ssh/sshd_config
>> +srv/web/ipfire/cgi-bin/connections.cgi
>> +srv/web/ipfire/cgi-bin/fireinfo.cgi
>> +srv/web/ipfire/cgi-bin/fwhosts.cgi
>> +srv/web/ipfire/cgi-bin/iptables.cgi
>> +srv/web/ipfire/cgi-bin/modem-status.cgi
>> srv/web/ipfire/cgi-bin/vulnerabilities.cgi
>> +srv/web/ipfire/cgi-bin/wirelessclient.cgi
>> usr/sbin/openvpn-authenticator
>> var/ipfire/header.pl
>> -- 
>> 2.51.0
>>
>>
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-13 16:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-13 11:15 [PATCH 1/2] cgi-bin: Apply consistent disable status to debug modules Adolf Belka
2025-10-13 11:15 ` [PATCH 2/2] core199: Ship modified cgi files Adolf Belka
2025-10-13 15:48   ` Michael Tremer
2025-10-13 16:04     ` Adolf Belka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox