From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Cc: Stefan Schantl <stefan.schantl@ipfire.org>
Subject: [PATCH 2/3] lldp.cgi: Call binary for peers and do json stuff only if the service is enabled
Date: Sat, 15 Nov 2025 11:07:57 +0100 [thread overview]
Message-ID: <20251115100758.7039-2-stefan.schantl@ipfire.org> (raw)
In-Reply-To: <20251115100758.7039-1-stefan.schantl@ipfire.org>
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
html/cgi-bin/lldp.cgi | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/html/cgi-bin/lldp.cgi b/html/cgi-bin/lldp.cgi
index 9e30faa92..194f4ec82 100644
--- a/html/cgi-bin/lldp.cgi
+++ b/html/cgi-bin/lldp.cgi
@@ -116,21 +116,21 @@ MAIN:
END
&Header::closebox();
- # Load data about all peers
- my @output = &General::system_output("lldpctl", "-f", "json0");
+ # Show a list with all peers if the service is enabled
+ if ($settings{"ENABLED"} eq "on") {
+ # Load data about all peers
+ my @output = &General::system_output("lldpctl", "-f", "json0");
- my $json;
+ my $json;
- # Parse the JSON output
- eval {
- $json = decode_json join("\n", @output);
- 1;
- } or do {
- $json = undef;
- };
+ # Parse the JSON output
+ eval {
+ $json = decode_json join("\n", @output);
+ 1;
+ } or do {
+ $json = undef;
+ };
- # Show a list with all peers if the service is enabled
- if ($settings{"ENABLED"} eq "on") {
&Header::opensection($Lang::tr{'lldp neighbors'});
# Fetch the interface object
--
2.47.3
next prev parent reply other threads:[~2025-11-15 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 10:07 [PATCH 1/3] lldp.cgi: Add mission validation for description field Stefan Schantl
2025-11-15 10:07 ` Stefan Schantl [this message]
2025-11-15 10:07 ` [PATCH 3/3] lldp.cgi: Show discovered peers in alphabetical order Stefan Schantl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251115100758.7039-2-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox