public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Cc: Stefan Schantl <stefan.schantl@ipfire.org>
Subject: [PATCH] ids.cgi: Fix sorting the ignored hosts by id
Date: Wed, 11 Mar 2026 20:39:50 +0100	[thread overview]
Message-ID: <20260311193950.6283-1-stefan.schantl@ipfire.org> (raw)
In-Reply-To: <5c23a258-3e27-4d84-a55d-4b24ff73770c@ipfire.org>

The sorting statement was entirely wrong, so the lists of ignored
hosts never got sorted in a proper way.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---
 html/cgi-bin/ids.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 192c71ec6..849c37528 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1506,7 +1506,7 @@ END
 			my $col = "";
 
 			# Loop through all entries of the hash.
-			foreach my $key (sort { $ignored{$a}[0] <=> $ignored{$b}[0] } keys %ignored)  {
+			foreach my $key (sort { $a <=> $b } keys %ignored)  {
 				# Assign data array positions to some nice variable names.
 				my $address = $ignored{$key}[0];
 				my $remark = $ignored{$key}[1];
-- 
2.47.3



  parent reply	other threads:[~2026-03-11 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 21:30 ids.cgi: Exception list changes display order and something more Matthias Fischer
2026-03-10  4:43 ` Stefan Schantl
2026-03-11 19:39 ` Stefan Schantl [this message]
2026-03-11 20:12 ` Stefan Schantl
2026-03-11 21:32   ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311193950.6283-1-stefan.schantl@ipfire.org \
    --to=stefan.schantl@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox