public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@mandelbit.com>
To: development@lists.ipfire.org
Cc: Antonio Quartulli <antonio@mandelbit.com>
Subject: [PATCH 2/2] dns.cgi: Force a reload after every change
Date: Fri, 13 Nov 2026 14:42:43 +0100	[thread overview]
Message-ID: <20261113134243.382773-3-antonio@mandelbit.com> (raw)
In-Reply-To: <20261113134243.382773-1-antonio@mandelbit.com>

The workers only set up DNS-over-TLS forwarders at startup, so after
enabling TLS they sent plain DNS to port 853 until knot-resolver was
restarted. Changes to the server list didn't reload at all.

Fixes: #14781
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
---
 html/cgi-bin/dns.cgi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
index 713b0a308..d0080f7b6 100644
--- a/html/cgi-bin/dns.cgi
+++ b/html/cgi-bin/dns.cgi
@@ -105,9 +105,6 @@ if ($cgiparams{'GENERAL'} eq _('Save')) {
 		# Call function to handle unbound restart, etc.
 		&_handle_unbound_and_more()
 	}
-
-	# Reload DNS
-	&General::system_background("/usr/local/bin/dnsctrl", "reload");
 }
 
 ###
@@ -823,6 +820,10 @@ END
 
 # Private function to handle the restart of unbound and more.
 sub _handle_unbound_and_more () {
+	# Reload DNS and restart the workers, as they only read the
+	# forwarders when they start
+	&General::system_background("/usr/local/bin/dnsctrl", "force-reload");
+
 	# Check if the IDS is running.
 	if(&IDS::ids_is_running()) {
 		# Re-generate the file which contains the DNS Server
-- 
2.56.0



      parent reply	other threads:[~2026-11-13 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 13:42 [PATCH 0/2] Fix DNS-over-TLS after changing DNS settings (#14781) Antonio Quartulli
2026-11-13 13:42 ` [PATCH 1/2] knot-resolver: Add force-reload Antonio Quartulli
2026-11-13 13:42 ` Antonio Quartulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113134243.382773-3-antonio@mandelbit.com \
    --to=antonio@mandelbit.com \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox