From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] iptables: Do not ship libxt_ddcp.so
Date: Mon, 21 Mar 2022 08:49:41 +0000
Message-ID: <20436F51-1442-4087-BF81-8736D57A568E@ipfire.org>
In-Reply-To: <8d581c78-6627-58ee-b095-055b895a810d@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6293270170862402703=="
List-Id: <development.lists.ipfire.org>

--===============6293270170862402703==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Peter,

I am not sure whether I like the patch.

It becomes difficult and tiresome to keep track of these changes when the nex=
t update is due and I would prefer it, if the file wouldn=E2=80=99t be there =
in the first place. Because then, the next update cannot accidentally ship th=
e file again.

Is there a =E2=80=94-disable-dccp option?

-Michael

> On 19 Mar 2022, at 15:32, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
> even available as a kernel module. Therefore, there is no sense in
> shipping this module, since it cannot do anything.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/rootfiles/common/iptables | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/ipt=
ables
> index b8bf748a5..559958b43 100644
> --- a/config/rootfiles/common/iptables
> +++ b/config/rootfiles/common/iptables
> @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
> lib/xtables/libxt_connmark.so
> lib/xtables/libxt_conntrack.so
> lib/xtables/libxt_cpu.so
> -lib/xtables/libxt_dccp.so
> +#lib/xtables/libxt_dccp.so
> lib/xtables/libxt_devgroup.so
> lib/xtables/libxt_dscp.so
> lib/xtables/libxt_ecn.so
> --=20
> 2.34.1


--===============6293270170862402703==--