Re: [PATCH] Revived as addon: squid graphs 3.2

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]

Hi,

On 13.11.2017 23:56, Michael Tremer wrote:
> Hi,
> 
> On Sun, 2017-11-12 at 11:11 +0100, Matthias Fischer wrote:
>> Hi,
>> 
>> On 12.11.2017 01:34, Matthias Fischer wrote:
>> > Hi,
>> > 
>> > For details see:
>> > https://sourceforge.net/projects/squid-graph/
>> > ...
>> 
>> Ok guys - sorry for the noise, but currently I'm not so fit as I'd like
>> to be (flu).
> 
> That's fine. Get better soon.
Y
>> After looking at my upload results in patchwork and GIT and - for
>> example - thinking about future updates I decided to rework this addon
>> from scratch. So for now I'll change this to 'under review' in patchwork.
>> 
>> Reasons for this:
>> During testing its installing and working ok, BUT(!)...
>> 
>> Publishing or merging 'squid-graph' the way I did would induce the need
>> to pack and upload a NEW archive every time something gets changed. Be
>> it a language-file or some script or some GUI-file or something else.
>> 
>> After looking at this, I thought it would be better and easier to
>> maintain this addon if I build and pack it like 'squid-accounting' or
>> 'wio' (e.g.).
> 
> Well, since there is an upstream project, I think it is probably best
> to use their tarball and have patches against the latest release.

Done. Patch was easy, lfs-file a bit tricky, but looking good now.

> However, this is indeed quite old, so it might make sense to fork it
> and have an own git repository to work on it and release every once in
> a while. Like we do with guardian...
> 
> Maybe it makes sense to get in touch with the original maintainer and
> see where that goes. That depends on what changes you are going to
> make.

I thought this over => created a sourceforge account today and sent an
email to the original maintainer (detach8?), asking if he would mind if
I adapt 'squid-graph 3.2 for IPFire. Waiting for response...

Best,
Matthias