From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2] WebUI: print more information on used nameservers
Date: Sun, 17 Sep 2017 09:39:37 +0200
Message-ID: <21e80198-bf62-b9b7-3650-6cecd20e5fc3@ipfire.org>
In-Reply-To: <20170908195822.6af0659b.peter.mueller@link38.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7991153615262455720=="
List-Id: <development.lists.ipfire.org>

--===============7991153615262455720==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Working on some 'cosmetics', I would suggest to add a few
"align=3D"center=3D" (Looks somehow better - please see below):

On 08.09.2017 19:58, Peter M=C3=BCller wrote:
> Show rDNS/PTR entry and country flag of the used nameservers on the
> nameserver status list at "netexternal.cgi".
>=20
> These information might be useful for debugging, or are just "nice to
> have" and do not harm anything. :-)
>=20
> Changes since v1: Corrected file link to country.cgi and added title to fla=
g.
> Please disregard the first version of this patch.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)link38.eu>
> ---
> diff --git a/html/cgi-bin/netexternal.cgi b/html/cgi-bin/netexternal.cgi
> index 299612d4c..6fe0cc7d6 100644
> --- a/html/cgi-bin/netexternal.cgi
> +++ b/html/cgi-bin/netexternal.cgi
> @@ -25,9 +25,13 @@ use strict;
>  #use warnings;
>  #use CGI::Carp 'fatalsToBrowser';
> =20
> +use IO::Socket;
> +use Geo::IP::PurePerl;
> +
>  require '/var/ipfire/general-functions.pl';
>  require "${General::swroot}/lang.pl";
>  require "${General::swroot}/header.pl";
> +require "${General::swroot}/geoip-functions.pl";
>  require "${General::swroot}/graphs.pl";
> =20
>  my %color =3D ();
> @@ -99,6 +103,12 @@ if ( $querry[0] ne~ ""){
>  						<strong>$Lang::tr{'nameserver'}</strong>
>  					</th>
>  					<th align=3D"center">
> +						<strong>$Lang::tr{'flag'}</strong>
> +					</th>
> +					<th align=3D"center">
> +						<strong>$Lang::tr{'rdns'}</strong>
> +					</th>
> +					<th align=3D"center">
>  						<strong>$Lang::tr{'status'}</strong>
>  					</th>
>  				</tr>
> @@ -139,9 +149,22 @@ END
> =20
>  		my $table_colour =3D ($id++ % 2) ? $color{'color22'} : $color{'color20'};
> =20
> +		# Get rDNS entry for nameserver (might be useful)
> +		my $iaddr =3D inet_aton($nameserver);
> +		my $rdns =3D gethostbyaddr($iaddr, AF_INET);
> +	        if (!$rdns) { $rdns =3D $Lang::tr{'lookup failed'}; }
> +	=09
> +		# Get country flag for the nameserver (might be useful)
> +		my $gi =3D Geo::IP::PurePerl->new();
> +	        my $ccode =3D $gi->country_code_by_name($nameserver);
> +       		my $fcode =3D lc($ccode);
> +	        my $flag_icon =3D &GeoIP::get_flag_icon($fcode);
> +
>  		print <<END;
>  			<tr bgcolor=3D"$table_colour">
>  				<td>$nameserver</td>

Changed to: <td align=3D"center">$nameserver</td>

> +				<td align=3D"center"><a href=3D"country.cgi#$fcode"><img src=3D"$flag_=
icon" border=3D"0" align=3D"absmiddle" alt=3D"$ccode" title=3D"$ccode"></a></=
td>=09
> +				<td>$rdns</td>

Changed to: <td align=3D"center">$rdns</td>

>  				<td bgcolor=3D"$bgcolour" align=3D"center">
>  					<font color=3D"$colour"><strong>$message</strong></font>
>  				</td>
> ...
...

Jm2C! ;-)

Best,
Matthias

--===============7991153615262455720==--