public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] transmission: revert version back to 4.0.5
Date: Thu, 02 Jan 2025 16:43:40 +0000	[thread overview]
Message-ID: <222E7AED-2509-413A-BD18-25DC3F61867F@ipfire.org> (raw)
In-Reply-To: <20250102162926.3561377-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2464 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

This looks perfect to me.

> On 2 Jan 2025, at 16:29, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> - Revert back from 4.0.6 to 4.0.5 due to a bug in 4.0.6 that has resulted in a variety
>   of torrent mirrors banning transmission-4.0.6
> - The update from 4.0.5 to 4.0.6 did not have any security fixes in it so there is no
>   issue in moving backward to 4.0.5
> - A fix has been created but it is unclear when (and if) version 4.0.7 will be released.
>   The fix has also been included in version 4.1.0 but this is still in beta development
>   form.
> - Version 4.0.6 required minupnpc for building and run time. This reversion is also
>   removing miniupnpc in an associated patch in this patch set.
> - No change required in the rootfile.
> 
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> lfs/transmission | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/lfs/transmission b/lfs/transmission
> index 49e024a13..c95c8b373 100644
> --- a/lfs/transmission
> +++ b/lfs/transmission
> @@ -26,7 +26,7 @@ include Config
> 
> SUMMARY    = A BitTorrent client with multiple UIs
> 
> -VER        = 4.0.6
> +VER        = 4.0.5
> 
> THISAPP    = transmission-$(VER)
> DL_FILE    = $(THISAPP).tar.xz
> @@ -34,9 +34,9 @@ DL_FROM    = $(URL_IPFIRE)
> DIR_APP    = $(DIR_SRC)/$(THISAPP)
> TARGET     = $(DIR_INFO)/$(THISAPP)
> PROG       = transmission
> -PAK_VER    = 24
> +PAK_VER    = 25
> 
> -DEPS       = miniupnpc
> +DEPS       =
> 
> SERVICES   = transmission
> 
> @@ -48,7 +48,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_BLAKE2 = 3eb1d851322299cb1b79c799f431c09db5aee1be0372fa2877e16508ca6f9e78ea42ed75520ab29a3325e62efcfca63a83559db73c39c981c9e2eddb403ef65a
> +$(DL_FILE)_BLAKE2 = 60caa3bc615137b225d3ac3f25daa352c6960fcc848c91e5ea45488ae109d93b53e314e4683bd7c4ef3f9b2f364d796b6c5bb014ca647d3f44fb5c9df9f8c997
> 
> install : $(TARGET)
> 
> @@ -81,7 +81,6 @@ $(subst %,%_BLAKE2,$(objects)) :
> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> @$(PREBUILD)
> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/transmission-4.0.6-fix_for_miniupnpc-2.2.8.patch
> cd $(DIR_APP) && cmake . \
> -DCMAKE_INSTALL_PREFIX=/usr \
> -DCMAKE_BUILD_TYPE=Release \
> -- 
> 2.47.1
> 


      parent reply	other threads:[~2025-01-02 16:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 16:29 Adolf Belka
2025-01-02 16:29 ` [PATCH 2/2] miniupnpc: revert the addition of this package due to transmission reversion Adolf Belka
2025-01-02 16:43 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=222E7AED-2509-413A-BD18-25DC3F61867F@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox