From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: libnfnetlink and libmnl Date: Wed, 06 Apr 2022 18:52:22 +0200 Message-ID: <23823e37-ef7e-eae7-015c-4dd6a018d3ea@ipfire.org> In-Reply-To: <52ec4aad-7ed8-fb3d-05e4-7f16e53bbd53@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0447153486562294336==" List-Id: --===============0447153486562294336== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 06/04/2022 17:38, Adolf Belka wrote: > Hi Michael, > > On 06/04/2022 16:42, Michael Tremer wrote: >> Hello Adolf, >> >>> On 6 Apr 2022, at 14:18, Adolf Belka wrote: >>> >>> Hi All, >>> >>> We have both libnfnetlink and libmnl in IPFire. I have just done an updat= e of libmnl. >>> There is an update of libnfnetlink but it also says that libnfnetlink is = still deprecated and should preferably be replaced by libmnl >> >> Oh this is very interesting. >> >> It looks like libmnl was introduced for conntrack-tools in this commit: >> >> commit a10733a5d8580b6ab8cff46235daab6547723781 >> Author: Arne Fitzenreiter >> Date:=C2=A0=C2=A0 Thu Jan 3 14:27:11 2013 +0100 >> >> =C2=A0=C2=A0=C2=A0=C2=A0 conntrack-tools: add conntrack and needed deps. >> >> You can try to comment out libnfnetlink and libmnl and run a clean build a= nd see if it goes through. If so, then we can safely drop them. >> It didn't go clean. It looks like libnetfilter_queue requires both libmnl and= libnfnetlink for compiling/building different parts of libnetfilter_queue. I= don't know if it is required for running but it wouldn't surprise me so both= these will have to stay. It's interesting that the group that says libmnl should be used in preference= to libnfnetlink then go and require both to still be used for one of their p= rograms. I will continue looking through other files that you highlighted. Regards, Adolf. >>> I have run ./make.sh find-dependencies on both libmnl.so.0.2.0 and libnfn= etlink.so.0.2.0 and neither came up with anything. Doing a grep on the git re= pository for mnl or nfnetlink also didn't indicate anything using these. >>> How are they being used and what needs to be done to change the usage of = libnfnetlink to libmnl? >> >> See above. >> >> I believe there are a couple of other candidates for this which we should = have a look at. There is libdnet that I noticed a little while ago, but I am = sure there will be plenty more when looking through the package list: >> >> libaio >> libart >> libnet >> libnl (and if something depends on it, can it not use libnl-3?) >> libpri (if I remember correctly this was a dependency of asterisk) >> libsolv can absolutely go for the moment, we don=E2=80=99t need it >> netpbm? >> pigz (we don=E2=80=99t use it anywhere since we are compressing images wit= h XZ b302b9a695e391477eab0cb2343f3ba1b1ba1989) >> sdparm >> >> If you have the time, maybe you can have a look at what is used somewhere = and what can be dropped? > I will give that a go and use your inputs as starting points. > > Regards, > Adolf >> >> This won=E2=80=99t shrink the distribution by a massive amount, but why sh= ould we carry around dead code? >> >> Best, >> -Michael >> >>> Regards, >>> Adolf >> --===============0447153486562294336==--