From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] fireinfo.cgi: improve readability of command outputs
Date: Sun, 08 Mar 2020 11:48:47 +0000 [thread overview]
Message-ID: <23874669-04EF-4176-B811-6DB1327DA6D7@ipfire.org> (raw)
In-Reply-To: <0faba960-9f85-1d39-41d6-6969cd91c1ed@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 7 Mar 2020, at 18:58, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Especially when it comes to the output of "uname -a", <code> tags
> greatly improve readability.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/fireinfo.cgi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/html/cgi-bin/fireinfo.cgi b/html/cgi-bin/fireinfo.cgi
> index 967e250c7..dfc741fde 100644
> --- a/html/cgi-bin/fireinfo.cgi
> +++ b/html/cgi-bin/fireinfo.cgi
> @@ -90,18 +90,18 @@ my $kernel_version = `uname -a`;
>
> &Header::openbox('100%', 'left', $Lang::tr{'fireinfo system version'});
> print <<END;
> - <table width="100%">
> + <table cellspacing='1' cellpadding='0' class='tbl'>
> <tr>
> - <td>$Lang::tr{'fireinfo ipfire version'}:</td>
> - <td>$ipfire_version</td>
> + <td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo ipfire version'}</td>
> + <td bgcolor='#F0F0F0'><code>$ipfire_version</code></td>
> </tr>
> <tr>
> - <td>$Lang::tr{'fireinfo pakfire version'}:</td>
> - <td>$pakfire_version</td>
> + <td align='center' bgcolor='#D6D6D6' width='15%'>$Lang::tr{'fireinfo pakfire version'}</td>
> + <td bgcolor='#D6D6D6'><code>$pakfire_version</code></td>
> </tr>
> <tr>
> - <td>$Lang::tr{'fireinfo kernel version'}:</td>
> - <td>$kernel_version</td>
> + <td align='center' bgcolor='#F0F0F0' width='15%'>$Lang::tr{'fireinfo kernel version'}</td>
> + <td bgcolor='#F0F0F0'><code>$kernel_version</code></td>
> </tr>
> </table>
> END
> --
> 2.16.4
prev parent reply other threads:[~2020-03-08 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 18:58 Peter Müller
2020-03-08 11:48 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23874669-04EF-4176-B811-6DB1327DA6D7@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox