From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] fireinfo.cgi: improve readability of command outputs
Date: Sun, 08 Mar 2020 11:48:47 +0000
Message-ID: <23874669-04EF-4176-B811-6DB1327DA6D7@ipfire.org>
In-Reply-To: <0faba960-9f85-1d39-41d6-6969cd91c1ed@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3742518304356416266=="
List-Id: <development.lists.ipfire.org>

--===============3742518304356416266==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 7 Mar 2020, at 18:58, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Especially when it comes to the output of "uname -a", <code> tags
> greatly improve readability.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/fireinfo.cgi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/html/cgi-bin/fireinfo.cgi b/html/cgi-bin/fireinfo.cgi
> index 967e250c7..dfc741fde 100644
> --- a/html/cgi-bin/fireinfo.cgi
> +++ b/html/cgi-bin/fireinfo.cgi
> @@ -90,18 +90,18 @@ my $kernel_version =3D `uname -a`;
>=20
> &Header::openbox('100%', 'left', $Lang::tr{'fireinfo system version'});
> print <<END;
> -	<table width=3D"100%">
> +	<table cellspacing=3D'1' cellpadding=3D'0' class=3D'tbl'>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo ipfire version'}:</td>
> -			<td>$ipfire_version</td>
> +			<td align=3D'center' bgcolor=3D'#F0F0F0' width=3D'15%'>$Lang::tr{'firei=
nfo ipfire version'}</td>
> +			<td bgcolor=3D'#F0F0F0'><code>$ipfire_version</code></td>
> 		</tr>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo pakfire version'}:</td>
> -			<td>$pakfire_version</td>
> +			<td align=3D'center' bgcolor=3D'#D6D6D6' width=3D'15%'>$Lang::tr{'firei=
nfo pakfire version'}</td>
> +			<td bgcolor=3D'#D6D6D6'><code>$pakfire_version</code></td>
> 		</tr>
> 		<tr>
> -			<td>$Lang::tr{'fireinfo kernel version'}:</td>
> -			<td>$kernel_version</td>
> +			<td align=3D'center' bgcolor=3D'#F0F0F0' width=3D'15%'>$Lang::tr{'firei=
nfo kernel version'}</td>
> +			<td bgcolor=3D'#F0F0F0'><code>$kernel_version</code></td>
> 		</tr>
> 	</table>
> END
> --=20
> 2.16.4


--===============3742518304356416266==--