From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer <michael.tremer@ipfire.org> To: development@lists.ipfire.org Subject: Re: [PATCH] boost: Fix rootfile entries that referred to python3.8 instead of 3.10 Date: Thu, 12 May 2022 10:27:00 +0100 Message-ID: <24C70DAE-D9B5-4910-BE96-5FAC94D9F769@ipfire.org> In-Reply-To: <2c3fea60-43b8-f8c2-758a-708490bc66e0@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4998874119184626551==" List-Id: <development.lists.ipfire.org> --===============4998874119184626551== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, If you need a clean build and you don=E2=80=99t have the capacity to run one = by yourself (which you should of course always have :D), then you can downloa= d the root files from the nightly builds: https://nightly.ipfire.org I sometimes do this to easily get root files that differ between architecture= s, because there is no need then to compile things myself again. I can just d= ownload the log file and edit it as I need. If you haven=E2=80=99t already done so, you can also sign up to the nightly b= uild mailing list and you will get a notification when a build finishes or fa= ils. The fails are very often related to the root files, so it is good to kno= w what went wrong were. https://lists.ipfire.org/mailman/listinfo/nightly-builds -Michael > On 8 May 2022, at 22:05, Adolf Belka <adolf.belka(a)ipfire.org> wrote: >=20 > Hi Peter, >=20 > Found an interesting difference between my existing repo and the new one I = created. Although it created the 310 versions in the build directory and adde= d them to the log file for boost the cdrom section passed without any problem= or error, so even though the build created the 310 version files nothing was= flagged in this new git clone. >=20 > Probably this is what was happening until a while ago when it started to fl= ag up the boost rootfile on my existing system. >=20 > If new lines have been added top the boost logfile I would expect that even= if the cdrom section passed that it would flag up "Changes in boost_1_76_0 c= heck rootfile!" but it did not. >=20 >=20 > Regards, >=20 > Adolf. >=20 > On 08/05/2022 16:10, Adolf Belka wrote: >> Hi Peter, >>=20 >> I realised that I could create a new clone of IPFire next without getting = rid of the old one so I did that. >>=20 >> I made no changes to anything and ran a build and it has just built boost,= including creating the 310 files >>=20 >> +usr/lib/libboost_python310-mt-x64.so >> +usr/lib/libboost_python310-mt-x64.so.1.76.0 >> +usr/lib/libboost_python310-x64.so >> +usr/lib/libboost_python310-x64.so.1.76.0 >>=20 >> +usr/lib/cmake/boost_python-1.76.0/libboost_python-variant-mt-x64-shared-p= y3.10.cmake >> +usr/lib/cmake/boost_python-1.76.0/libboost_python-variant-x64-shared-py3.= 10.cmake >>=20 >> So for me using ipfire clones git it is building the 310 versions and ther= efore expects to see the .so.1.76.0 lines in the rootfile when it gets to the= cdrom stage. The 310 versions are in the build directory and not the 38 ones >>=20 >>=20 >> Regards, >>=20 >> Adolf. >>=20 >>=20 >> On 06/05/2022 15:55, Adolf Belka wrote: >>> Hi Peter, >>>=20 >>> I have attached at the end of this email the _build.ipfire.log section ju= st for boost from my system. There are sections where it can be seen to be co= mpiling the 310 versions of the libraries. Maybe you could compare that log f= ile with what is created on your build machine for boost. Maybe that can help= indicate why yours builds the 38 versions and mine the 310 versions. >>>=20 >>> Regards, >>>=20 >>> Adolf. >>>=20 >>>=20 >>> On 06/05/2022 15:40, Adolf Belka wrote: >>>> Hi Peter, >>>>=20 >>>> I saw that you had reverted this change because it didn't work on your b= uild. That is interesting. >>>>=20 >>>>=20 >>>> Until about a week ago I also had no problems with boost but now with th= e existing rootfiles each time I do a build in the boost log file it now crea= tes the 310 version and removes the 38 version >>>>=20 >>>> +usr/lib/libboost_python310-mt-x64.so >>>> +usr/lib/libboost_python310-mt-x64.so.1.76.0 >>>> +usr/lib/libboost_python310-x64.so >>>> +usr/lib/libboost_python310-x64.so.1.76.0 >>>>=20 >>>> -usr/lib/libboost_python38-mt-x64.so.1.76.0 >>>> -usr/lib/libboost_python38-x64.so.1.76.0 >>>>=20 >>>> and today when I did a build I got an additional two + lines for the boo= st rootfile >>>>=20 >>>> +usr/lib/cmake/boost_python-1.76.0/libboost_python-variant-mt-x64-shared= -py3.10.cmake >>>> +usr/lib/cmake/boost_python-1.76.0/libboost_python-variant-x64-shared-py= 3.10.cmake >>>>=20 >>>> These two I did not have before today. Not sure what is happening here. >>>>=20 >>>> Because of the above + lines when I get to the cdrom stage I get the fol= lowing error message >>>>=20 >>>> tar: usr/lib/libboost_python38-mt-x64.so.1.76.0: Cannot stat: No suc= h file or directory >>>> tar: usr/lib/libboost_python38-x64.so.1.76.0: Cannot stat: No such f= ile or directory >>>> tar: Exiting with failure status due to previous errors >>>> make: *** [cdrom:156: /usr/src/log/cdrom] Error 2 >>>>=20 >>>> I had thought that because my build was having boost create these files = that the same would be happening with everyone else's builds but it looks lik= e not. >>>>=20 >>>> The question then is why has it started to do the new rootfiles, which m= ake some sense because they are 310 versions and we are on python-3.10 but wh= y didn't it do it before and why only on my build. >>>>=20 >>>> Other than doing a git pull before each build, that I normally do, I hav= en't done anything else that I can think of to cause this but I may also have= done something unintentionally and unknowingly. >>>>=20 >>>> So at the moment I need to have the 310 versions in my boost rootfiles o= r all builds fail at the cdrom stage but I will not create any patches for th= em while we investigate what is happening. >>>>=20 >>>> Any suggestions for what I should look for on my system would be appreci= ated. >>>>=20 >>>> If I have to clear my local git repository and start again with a fresh = git clone, then I will do so but would prefer not to because starting again w= ill mean my first build is much longer but, hey ho, if that is needed I will = do it. >>>>=20 >>>>=20 >>>> Regards, >>>>=20 >>>> Adolf. >>>>=20 >>>>=20 >>>> On 04/05/2022 21:43, Peter M=C3=BCller wrote: >>>>> Good catch, thank you! >>>>>=20 >>>>> Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org> >>>>>=20 >>>>>> - In Jan 2022 I updated python from 3.8 to 3.10 but I missed that boos= t had rootfile >>>>>> entries with python38 in it. >>>>>> - Running a build just now for another package it got flagged up that = the rootfile for >>>>>> boost had been changed and the logfile now had the entries with py= thon310 instead of >>>>>> python38 >>>>>> - Not clear why it only flagged this up now but this patch is to corre= ct that error >>>>>> - Running find-dependencies on both the pyton38 and python310 versions= of the libraries >>>>>> flagged nothing as being linked to either, so probably lucky with t= his being missed >>>>>> first time around. >>>>>> - Boost will need to be shipped with a Core Update >>>>>>=20 >>>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org> >>>>>> --- >>>>>> config/rootfiles/common/aarch64/boost | 8 ++++---- >>>>>> config/rootfiles/common/armv6l/boost | 8 ++++---- >>>>>> config/rootfiles/common/x86_64/boost | 8 ++++---- >>>>>> 3 files changed, 12 insertions(+), 12 deletions(-) >>>>>>=20 >>>>>> diff --git a/config/rootfiles/common/aarch64/boost b/config/rootfiles/= common/aarch64/boost >>>>>> index 49ff120ab..015dc1458 100644 >>>>>> --- a/config/rootfiles/common/aarch64/boost >>>>>> +++ b/config/rootfiles/common/aarch64/boost >>>>>> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-a64.so.1.76.0 >>>>>> usr/lib/libboost_prg_exec_monitor-mt-a64.so.1.76.0 >>>>>> #usr/lib/libboost_prg_exec_monitor-a64.so >>>>>> usr/lib/libboost_prg_exec_monitor-a64.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-mt-a64.so >>>>>> -usr/lib/libboost_python38-mt-a64.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-a64.so >>>>>> -usr/lib/libboost_python38-a64.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-mt-a64.so >>>>>> +usr/lib/libboost_python310-mt-a64.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-a64.so >>>>>> +usr/lib/libboost_python310-a64.so.1.76.0 >>>>>> #usr/lib/libboost_random-mt-a64.so >>>>>> usr/lib/libboost_random-mt-a64.so.1.76.0 >>>>>> #usr/lib/libboost_random-a64.so >>>>>> diff --git a/config/rootfiles/common/armv6l/boost b/config/rootfiles/c= ommon/armv6l/boost >>>>>> index 80cc4063a..79e9ed3d7 100644 >>>>>> --- a/config/rootfiles/common/armv6l/boost >>>>>> +++ b/config/rootfiles/common/armv6l/boost >>>>>> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-mt-a32.so.1.76.0 >>>>>> usr/lib/libboost_prg_exec_monitor-a32.so.1.76.0 >>>>>> #usr/lib/libboost_prg_exec_monitor-mt-a32.so >>>>>> usr/lib/libboost_prg_exec_monitor-mt-a32.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-a32.so >>>>>> -usr/lib/libboost_python38-a32.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-mt-a32.so >>>>>> -usr/lib/libboost_python38-mt-a32.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-a32.so >>>>>> +usr/lib/libboost_python310-a32.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-mt-a32.so >>>>>> +usr/lib/libboost_python310-mt-a32.so.1.76.0 >>>>>> #usr/lib/libboost_random-a32.so >>>>>> usr/lib/libboost_random-a32.so.1.76.0 >>>>>> #usr/lib/libboost_random-mt-a32.so >>>>>> diff --git a/config/rootfiles/common/x86_64/boost b/config/rootfiles/c= ommon/x86_64/boost >>>>>> index 357dc2d1d..77eef1d0b 100644 >>>>>> --- a/config/rootfiles/common/x86_64/boost >>>>>> +++ b/config/rootfiles/common/x86_64/boost >>>>>> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-x64.so.1.76.0 >>>>>> usr/lib/libboost_prg_exec_monitor-mt-x64.so.1.76.0 >>>>>> #usr/lib/libboost_prg_exec_monitor-x64.so >>>>>> usr/lib/libboost_prg_exec_monitor-x64.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-mt-x64.so >>>>>> -usr/lib/libboost_python38-mt-x64.so.1.76.0 >>>>>> -#usr/lib/libboost_python38-x64.so >>>>>> -usr/lib/libboost_python38-x64.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-mt-x64.so >>>>>> +usr/lib/libboost_python310-mt-x64.so.1.76.0 >>>>>> +#usr/lib/libboost_python310-x64.so >>>>>> +usr/lib/libboost_python310-x64.so.1.76.0 >>>>>> #usr/lib/libboost_random-mt-x64.so >>>>>> usr/lib/libboost_random-mt-x64.so.1.76.0 >>>>>> #usr/lib/libboost_random-x64.so --===============4998874119184626551==--