public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] New package: IPTraffic 0.8.2
Date: Thu, 28 Jan 2021 11:08:38 +0100	[thread overview]
Message-ID: <24b40a41-7396-0973-cd43-66d9e9e49d4e@ipfire.org> (raw)
In-Reply-To: <29a71fd3-9116-0c94-0b5e-7819650d5261@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

Hi,

[shortened for better readability]

On 27.01.2021 19:36, Matthias Fischer wrote:
> ...
>>>> ...
>>>> Thank you for submitting the patch.
>>>> 
>>>> It is great to see more people taking part in development tasks, but I am not really sure what has been done here.
>>>> 
>>>> The main problem is that I do not know what IPTraffic does, or how it works. The code is in a tarball and I am not aware if there is a Git repository to see what has been changed over time.
> 
> I'm working on this.
>>> ...
>> What do you suggest we should do right now?
> 
> As a start, I rewrote the whole building and installation process - I
> got rid of the tarball. I would test if its ok  - one of the 'Devels' is
> already working on it - and building as expected and then push it to GIT
> / Patchwork. This would make the current code readable and transparent
> to everybody.

Done. Sent a reworked version.

> 
> Suggestion:
> Then "someone" (sorry, not me, thats far beyond my capabilities) should
> be able to decide whether she/he is able to use and rewrite the existing
> code to eliminate the disussed "shortcomings" (Google translate, I don't
> know if this fits!) and if it can be integrated or publishd as an addon.
> I can't decide if it would be better to start from scratch, see above
> (Bernhards comments).

Best,
Matthias

  reply	other threads:[~2021-01-28 10:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 17:15 Matthias Fischer
2021-01-25 19:27 ` Michael Tremer
2021-01-25 19:51   ` Frank Mainz
2021-01-25 20:05     ` Michael Tremer
2021-01-26 16:45   ` Matthias Fischer
2021-01-26 17:03     ` Aw: " Bernhard Bitsch
2021-01-27 11:32     ` Michael Tremer
2021-01-27 18:36       ` Matthias Fischer
2021-01-28 10:08         ` Matthias Fischer [this message]
     [not found] <2cc215c55a63d98924de4db8780ebf7ca89aefd7.camel@cybermainzel.de>
2021-01-25 20:48 ` Michael Tremer
2021-01-25 20:58   ` Frank Mainz
2021-01-25 21:01     ` Michael Tremer
2021-01-25 21:50 Aw: " Bernhard Bitsch
2021-01-26 11:38 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24b40a41-7396-0973-cd43-66d9e9e49d4e@ipfire.org \
    --to=matthias.fischer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox