[PATCH] make.sh: Suppress 'ls :cannot access *.bz2'-message

[PATCH] make.sh: Suppress 'ls :cannot access *.bz2'-message

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

The message "ls: cannot access '*.bz2': No such file or directory" comes
from the 'ls' command prior to creating the *.md5-files for *.bz2, *.img.xz
and *.iso files.

But on most builds we have especially no more bzip2 compressed images anymore.

This message can usually be ignored and is just irritating.

Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
 make.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/make.sh b/make.sh
index 4acce807f..2e8faa38d 100755
--- a/make.sh
+++ b/make.sh
@@ -1707,7 +1707,7 @@ buildpackages() {
   # remove not useable iso on armv5tel (needed to build flash images)
   [ "${BUILD_ARCH}" = "armv5tel" ] && rm -rf *.iso
 
-  for i in `ls *.bz2 *.img.xz *.iso`; do
+  for i in $(ls *.bz2 *.img.xz *.iso 2>/dev/null); do
 	md5sum $i > $i.md5
   done
   cd $PWD
-- 
2.18.0

Re: [PATCH] make.sh: Suppress 'ls :cannot access *.bz2'-message

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 24 May 2020, at 23:13, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> The message "ls: cannot access '*.bz2': No such file or directory" comes
> from the 'ls' command prior to creating the *.md5-files for *.bz2, *.img.xz
> and *.iso files.
> 
> But on most builds we have especially no more bzip2 compressed images anymore.
> 
> This message can usually be ignored and is just irritating.
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> make.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/make.sh b/make.sh
> index 4acce807f..2e8faa38d 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1707,7 +1707,7 @@ buildpackages() {
>   # remove not useable iso on armv5tel (needed to build flash images)
>   [ "${BUILD_ARCH}" = "armv5tel" ] && rm -rf *.iso
> 
> -  for i in `ls *.bz2 *.img.xz *.iso`; do
> +  for i in $(ls *.bz2 *.img.xz *.iso 2>/dev/null); do
> 	md5sum $i > $i.md5
>   done
>   cd $PWD
> -- 
> 2.18.0
>