From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism
Date: Wed, 27 Mar 2024 20:42:39 +0100
Message-ID: <263de5edf5246d928423b7ca971f57c703de21d9.camel@ipfire.org>
In-Reply-To: <BA34F59C-D0FF-4436-9B1E-91C5E6DD9C5F@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5506139382060528097=="
List-Id: <development.lists.ipfire.org>

--===============5506139382060528097==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Am Mittwoch, dem 27.03.2024 um 10:15 +0000 schrieb Michael Tremer:
> 
> 
> > On 27 Mar 2024, at 05:15, Stefan Schantl
> > <stefan.schantl(a)ipfire.org> wrote:
> > 
> > This case is already covered by the PID mechanism of the used
> > functions
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > src/initscripts/system/grub-btrfsd | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/initscripts/system/grub-btrfsd
> > b/src/initscripts/system/grub-btrfsd
> > index 26760f9be..5981c3a0a 100644
> > --- a/src/initscripts/system/grub-btrfsd
> > +++ b/src/initscripts/system/grub-btrfsd
> > @@ -33,15 +33,14 @@ case "$1" in
> > btrfs)
> > 
> > boot_mesg "Starting GRUB/Btrfs Daemon..."
> > - loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog
> > "$SNAPSHOTDIR"
> > - echo "$!" > "$PIDFILE"
> > + loadproc -b /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
> > ;;
> > esac
> > ;;
> > 
> > stop)
> > boot_mesg "Stopping grub-btrfsd..."
> > - killproc -p "$PIDFILE" /usr/bin/grub-btrfsd
> > + killproc -p /usr/bin/grub-btrfsd
> > sleep 1;
> 
> Why is there a sleep here?
Good catch, that's a classical orphaned piece of code when removing
some other stuff.

I'll handle it in a v2 patchset.
> 
> > ;;
> > 
> > -- 
> > 2.39.2
> > 
> 


--===============5506139382060528097==--