From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug
Date: Tue, 17 Jan 2023 15:08:15 +0100 [thread overview]
Message-ID: <28856750-e5d6-db18-ebd5-326b5635d192@ipfire.org> (raw)
In-Reply-To: <20230117140358.3564163-1-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2547 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 17.01.2023 um 15:03 schrieb Adolf Belka:
> - In six places <td class'base'> has been used instead of <td class='base'>
> - This patch fixes that error - tested on my vm testbed. Selecting Inspect Element now
> shows the corrrect result rather than class 'base' being set to null.
>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 2d19301a6..42a7354fc 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2710,7 +2710,7 @@ print <<END;
> <hr size='1'>
> <table width='100%'>
> <tr>
> - <td class'base'><b>$Lang::tr{'misc-options'}</b></td>
> + <td class='base'><b>$Lang::tr{'misc-options'}</b></td>
> </tr>
>
> <tr>
> @@ -2765,7 +2765,7 @@ print <<END;
> <hr size='1'>
> <table width='100%'>
> <tr>
> - <td class'base'><b>$Lang::tr{'log-options'}</b></td>
> + <td class='base'><b>$Lang::tr{'log-options'}</b></td>
> </tr>
> <tr>
> <td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
> @@ -4648,7 +4648,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
> <tr><td colspan=4><hr /></td></tr><tr>
>
> <tr>
> - <td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
> + <td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
> </tr>
>
> <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
> @@ -4672,7 +4672,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>
> <tr><td colspan=4><hr /></td></tr><tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> + <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> </tr>
>
> <tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
> @@ -5222,7 +5222,7 @@ END
>
> <tr><td colspan='4'><br></td></tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'net config'}:</b></td>
> + <td class='base'><b>$Lang::tr{'net config'}:</b></td>
> </tr>
> <tr><td colspan='1'><br></td></tr>
>
> @@ -5239,7 +5239,7 @@ END
>
> <tr><td colspan='4'><br></td></tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> + <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> </tr>
> <tr><td colspan='1'><br></td></tr>
>
prev parent reply other threads:[~2023-01-17 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:03 Adolf Belka
2023-01-17 14:08 ` Bernhard Bitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28856750-e5d6-db18-ebd5-326b5635d192@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox