From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug
Date: Tue, 17 Jan 2023 15:08:15 +0100
Message-ID: <28856750-e5d6-db18-ebd5-326b5635d192@ipfire.org>
In-Reply-To: <20230117140358.3564163-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2555779554734349204=="
List-Id: <development.lists.ipfire.org>

--===============2555779554734349204==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 17.01.2023 um 15:03 schrieb Adolf Belka:
> - In six places <td class'base'> has been used instead of <td class=3D'base=
'>
> - This patch fixes that error - tested on my vm testbed. Selecting Inspect =
Element now
>     shows the corrrect result rather than class 'base' being set to null.
>=20
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   html/cgi-bin/ovpnmain.cgi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 2d19301a6..42a7354fc 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2710,7 +2710,7 @@ print <<END;
>   <hr size=3D'1'>
>   <table width=3D'100%'>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'misc-options'}</b></td>
> +		<td class=3D'base'><b>$Lang::tr{'misc-options'}</b></td>
>   	</tr>
>  =20
>   	<tr>
> @@ -2765,7 +2765,7 @@ print <<END;
>   <hr size=3D'1'>
>   <table width=3D'100%'>
>       <tr>
> -	<td class'base'><b>$Lang::tr{'log-options'}</b></td>
> +	<td class=3D'base'><b>$Lang::tr{'log-options'}</b></td>
>       </tr>
>       <tr>
>   	<td width=3D'20%'></td> <td width=3D'30%'> </td><td width=3D'25%'> </td>=
<td width=3D'25%'></td>
> @@ -4648,7 +4648,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>   	<tr><td colspan=3D4><hr /></td></tr><tr>
>  =20
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
> +		<td class=3D'base'><b>$Lang::tr{'MTU settings'}</b></td>
>   	</tr>
>  =20
>           <tr><td class=3D'boldbase' nowrap=3D'nowrap'>$Lang::tr{'MTU'}</td>
> @@ -4672,7 +4672,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>  =20
>   <tr><td colspan=3D4><hr /></td></tr><tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> +		<td class=3D'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
>   	</tr>
>  =20
>   	<tr><td class=3D'boldbase'>$Lang::tr{'cipher'}</td>
> @@ -5222,7 +5222,7 @@ END
>  =20
>   	<tr><td colspan=3D'4'><br></td></tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'net config'}:</b></td>
> +		<td class=3D'base'><b>$Lang::tr{'net config'}:</b></td>
>   	</tr>
>       <tr><td colspan=3D'1'><br></td></tr>
>  =20
> @@ -5239,7 +5239,7 @@ END
>  =20
>   	<tr><td colspan=3D'4'><br></td></tr>
>   	<tr>
> -		<td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> +		<td class=3D'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
>   	</tr>
>   	<tr><td colspan=3D'1'><br></td></tr>
>  =20

--===============2555779554734349204==--