* [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug
@ 2023-01-17 14:03 Adolf Belka
2023-01-17 14:08 ` Bernhard Bitsch
0 siblings, 1 reply; 2+ messages in thread
From: Adolf Belka @ 2023-01-17 14:03 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2287 bytes --]
- In six places <td class'base'> has been used instead of <td class='base'>
- This patch fixes that error - tested on my vm testbed. Selecting Inspect Element now
shows the corrrect result rather than class 'base' being set to null.
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
html/cgi-bin/ovpnmain.cgi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 2d19301a6..42a7354fc 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -2710,7 +2710,7 @@ print <<END;
<hr size='1'>
<table width='100%'>
<tr>
- <td class'base'><b>$Lang::tr{'misc-options'}</b></td>
+ <td class='base'><b>$Lang::tr{'misc-options'}</b></td>
</tr>
<tr>
@@ -2765,7 +2765,7 @@ print <<END;
<hr size='1'>
<table width='100%'>
<tr>
- <td class'base'><b>$Lang::tr{'log-options'}</b></td>
+ <td class='base'><b>$Lang::tr{'log-options'}</b></td>
</tr>
<tr>
<td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
@@ -4648,7 +4648,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
<tr><td colspan=4><hr /></td></tr><tr>
<tr>
- <td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
+ <td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
</tr>
<tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
@@ -4672,7 +4672,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
<tr><td colspan=4><hr /></td></tr><tr>
<tr>
- <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+ <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
</tr>
<tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
@@ -5222,7 +5222,7 @@ END
<tr><td colspan='4'><br></td></tr>
<tr>
- <td class'base'><b>$Lang::tr{'net config'}:</b></td>
+ <td class='base'><b>$Lang::tr{'net config'}:</b></td>
</tr>
<tr><td colspan='1'><br></td></tr>
@@ -5239,7 +5239,7 @@ END
<tr><td colspan='4'><br></td></tr>
<tr>
- <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
+ <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
</tr>
<tr><td colspan='1'><br></td></tr>
--
2.39.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug
2023-01-17 14:03 [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug Adolf Belka
@ 2023-01-17 14:08 ` Bernhard Bitsch
0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Bitsch @ 2023-01-17 14:08 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2547 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 17.01.2023 um 15:03 schrieb Adolf Belka:
> - In six places <td class'base'> has been used instead of <td class='base'>
> - This patch fixes that error - tested on my vm testbed. Selecting Inspect Element now
> shows the corrrect result rather than class 'base' being set to null.
>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 2d19301a6..42a7354fc 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2710,7 +2710,7 @@ print <<END;
> <hr size='1'>
> <table width='100%'>
> <tr>
> - <td class'base'><b>$Lang::tr{'misc-options'}</b></td>
> + <td class='base'><b>$Lang::tr{'misc-options'}</b></td>
> </tr>
>
> <tr>
> @@ -2765,7 +2765,7 @@ print <<END;
> <hr size='1'>
> <table width='100%'>
> <tr>
> - <td class'base'><b>$Lang::tr{'log-options'}</b></td>
> + <td class='base'><b>$Lang::tr{'log-options'}</b></td>
> </tr>
> <tr>
> <td width='20%'></td> <td width='30%'> </td><td width='25%'> </td><td width='25%'></td>
> @@ -4648,7 +4648,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
> <tr><td colspan=4><hr /></td></tr><tr>
>
> <tr>
> - <td class'base'><b>$Lang::tr{'MTU settings'}</b></td>
> + <td class='base'><b>$Lang::tr{'MTU settings'}</b></td>
> </tr>
>
> <tr><td class='boldbase' nowrap='nowrap'>$Lang::tr{'MTU'}</td>
> @@ -4672,7 +4672,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>
> <tr><td colspan=4><hr /></td></tr><tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> + <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> </tr>
>
> <tr><td class='boldbase'>$Lang::tr{'cipher'}</td>
> @@ -5222,7 +5222,7 @@ END
>
> <tr><td colspan='4'><br></td></tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'net config'}:</b></td>
> + <td class='base'><b>$Lang::tr{'net config'}:</b></td>
> </tr>
> <tr><td colspan='1'><br></td></tr>
>
> @@ -5239,7 +5239,7 @@ END
>
> <tr><td colspan='4'><br></td></tr>
> <tr>
> - <td class'base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> + <td class='base'><b>$Lang::tr{'ovpn crypt options'}:</b></td>
> </tr>
> <tr><td colspan='1'><br></td></tr>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-17 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 14:03 [PATCH] ovpnmain.cgi: Fix for bug 13030 - Table style rendering bug Adolf Belka
2023-01-17 14:08 ` Bernhard Bitsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox