public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 7/7] pakfire.cgi: Cosmetic fixes
Date: Sun, 08 May 2022 13:12:53 +0000	[thread overview]
Message-ID: <29a3aed3-6448-6fab-3e20-a0bd10b9c8d8@ipfire.org> (raw)
In-Reply-To: <20220508120952.52-7-hofmann@leo-andres.de>

[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]

Acked-by: Peter Müller <peter.muelle(a)ipfire.org>

> Add formatting to improve readability of dependencies list header.
> 
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  html/cgi-bin/pakfire.cgi | 6 ++++--
>  langs/fr/cgi-bin/fr.pl   | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
> index 489b07a6d..3e8dc5460 100644
> --- a/html/cgi-bin/pakfire.cgi
> +++ b/html/cgi-bin/pakfire.cgi
> @@ -283,7 +283,8 @@ if (($cgiparams{'ACTION'} eq 'install') && ($pagemode eq $PM_DEFAULT)) {
>  	my @pkgs = split(/\|/, $cgiparams{'INSPAKS'});
>  	my @output = &General::system_output("/usr/local/bin/pakfire", "resolvedeps", "--no-colors", @pkgs);
>  	print <<END;
> -	<table><tr><td colspan='2'>$Lang::tr{'pakfire install package'} @pkgs $Lang::tr{'pakfire possible dependency'}
> +	<table style="width: 100%"><tr><td colspan='2'><p>$Lang::tr{'pakfire install package'} <strong>@{pkgs}</strong><br>
> +		$Lang::tr{'pakfire possible dependency'}</p>
>  		<pre>
>  END
>  	foreach (@output) {
> @@ -321,7 +322,8 @@ END
>  	my @pkgs = split(/\|/, $cgiparams{'DELPAKS'});
>  	my @output = &General::system_output("/usr/local/bin/pakfire", "resolvedeps", "--no-colors", @pkgs);
>  	print <<END;
> -	<table><tr><td colspan='2'>$Lang::tr{'pakfire uninstall package'} @pkgs $Lang::tr{'pakfire possible dependency'}
> +	<table style="width: 100%"><tr><td colspan='2'><p>$Lang::tr{'pakfire uninstall package'} <strong>@{pkgs}</strong><br>
> +		$Lang::tr{'pakfire possible dependency'}</p>
>  		<pre>
>  END
>  	foreach (@output) {
> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl
> index bd17df4ee..6dbeebc16 100644
> --- a/langs/fr/cgi-bin/fr.pl
> +++ b/langs/fr/cgi-bin/fr.pl
> @@ -2055,7 +2055,7 @@
>  'pakfire last package update' => 'Dernière mise à jour de la liste des paquets : ',
>  'pakfire last serverlist update' => 'Dernière mise à jour de la liste des serveurs : ',
>  'pakfire last update' => 'Dernière mise à jour : ',
> -'pakfire possible dependency' => '<br><br>Il y a peut-être des dépendances, voici la liste des paquets qu\'il faut (dés)installer.<br>',
> +'pakfire possible dependency' => 'Il y a peut-être des dépendances, voici la liste des paquets qu\'il faut (dés)installer.',
>  'pakfire register' => 'S\'inscrire au serveur pakfire :',
>  'pakfire return' => 'Retour à Pakfire',
>  'pakfire system state' => 'Statut système PakFire ',

  reply	other threads:[~2022-05-08 13:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 12:09 [PATCH 1/7] pakfire.cgi: Separate command processing and HTML generation Leo-Andres Hofmann
2022-05-08 12:09 ` [PATCH 2/7] pakfire.cgi: Fix indentation Leo-Andres Hofmann
2022-05-08 13:11   ` Peter Müller
2022-05-08 12:09 ` [PATCH 3/7] pakfire.cgi: Show error and log messages earlier Leo-Andres Hofmann
2022-05-08 13:12   ` Peter Müller
2022-05-08 12:09 ` [PATCH 4/7] pakfire.cgi: Notify user if Pakfire is already performing a task Leo-Andres Hofmann
2022-05-08 13:12   ` Peter Müller
2022-05-08 12:09 ` [PATCH 5/7] pakfire.cgi: Implement Post/Redirect/Get pattern Leo-Andres Hofmann
2022-05-08 13:12   ` Peter Müller
2022-05-12  9:30   ` Michael Tremer
2022-05-20  9:47     ` hofmann
2022-05-08 12:09 ` [PATCH 6/7] pakfire.cgi: Discard tac stderr output Leo-Andres Hofmann
2022-05-08 13:12   ` Peter Müller
2022-05-08 12:09 ` [PATCH 7/7] pakfire.cgi: Cosmetic fixes Leo-Andres Hofmann
2022-05-08 13:12   ` Peter Müller [this message]
2022-05-08 13:11 ` [PATCH 1/7] pakfire.cgi: Separate command processing and HTML generation Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a3aed3-6448-6fab-3e20-a0bd10b9c8d8@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox