Re: [PATCH] en.pl: Correct minor typo - bug#12701

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 12301 bytes --]

Hi Michael,

On 14/10/2021 21:04, Michael Tremer wrote:
> Hello,
> 
> I would interpret the lack of responses as a very quiet nod.
I had the same conclusion.
> 
> If you like, you could go ahead and submit a patch. It would be very much appreciated :)
I will do so.
> 
> -Michael
Adolf
> 
>> On 9 Oct 2021, at 14:31, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hallo,
>>
>> On 09/10/2021 14:14, Michael Tremer wrote:
>>> Hello,
>>> I wanted to respond to the ticket but didn’t have time, yet.
>>> I think this entire sentence should go. It is useless, as in: Everything else needs additional configuration.
>> I see what you mean. It applies also to other sections but they don't have any message.
>>> It does not make much sense to mark this in one field. We should rather use the new feature that Leo proposed where you are being brought to a wiki page which should have all information you need.
>> With the link from Leo in place then this statement becomes a bit redundant so I would agree with removing it.
>> I will wait to see the overall decision and redo the patch as appropriate.
>>> How do we feel about this?
>>> -Michael
>>>> On 9 Oct 2021, at 09:31, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>
>>>> - Corrected minor typo in the en.pl file - bug#12701
>>>>
>>>> Fixes: 12701
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>> doc/language_issues.en | 2 +-
>>>> doc/language_issues.es | 2 +-
>>>> doc/language_issues.it | 2 +-
>>>> doc/language_issues.nl | 2 +-
>>>> doc/language_issues.pl | 2 +-
>>>> doc/language_issues.ru | 2 +-
>>>> doc/language_issues.tr | 2 +-
>>>> langs/en/cgi-bin/en.pl | 2 +-
>>>> 8 files changed, 8 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/doc/language_issues.en b/doc/language_issues.en
>>>> index 3d10bebc6..fce67b8eb 100644
>>>> --- a/doc/language_issues.en
>>>> +++ b/doc/language_issues.en
>>>> @@ -299,7 +299,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: age second = second
>>>> diff --git a/doc/language_issues.es b/doc/language_issues.es
>>>> index 2e58b5b02..60612f9df 100644
>>>> --- a/doc/language_issues.es
>>>> +++ b/doc/language_issues.es
>>>> @@ -814,7 +814,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: age second = second
>>>> diff --git a/doc/language_issues.it b/doc/language_issues.it
>>>> index 4538461c6..af409c1db 100644
>>>> --- a/doc/language_issues.it
>>>> +++ b/doc/language_issues.it
>>>> @@ -903,7 +903,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>>>> diff --git a/doc/language_issues.nl b/doc/language_issues.nl
>>>> index 85fdcbe44..e6ad0d425 100644
>>>> --- a/doc/language_issues.nl
>>>> +++ b/doc/language_issues.nl
>>>> @@ -898,7 +898,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>>>> diff --git a/doc/language_issues.pl b/doc/language_issues.pl
>>>> index a023bdbee..52b8bd4aa 100644
>>>> --- a/doc/language_issues.pl
>>>> +++ b/doc/language_issues.pl
>>>> @@ -829,7 +829,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: age second = second
>>>> diff --git a/doc/language_issues.ru b/doc/language_issues.ru
>>>> index d1abbc4a8..7928cc948 100644
>>>> --- a/doc/language_issues.ru
>>>> +++ b/doc/language_issues.ru
>>>> @@ -825,7 +825,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: age second = second
>>>> diff --git a/doc/language_issues.tr b/doc/language_issues.tr
>>>> index a882db069..6ec856e17 100644
>>>> --- a/doc/language_issues.tr
>>>> +++ b/doc/language_issues.tr
>>>> @@ -890,7 +890,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>>>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>>>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>>>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>>>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>>>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>>>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
>>>> index 679588940..1a7c37294 100644
>>>> --- a/langs/en/cgi-bin/en.pl
>>>> +++ b/langs/en/cgi-bin/en.pl
>>>> @@ -400,7 +400,7 @@
>>>> 'advproxy wpad example dst_noproxy_url' => 'e.g. *.ipfire.org*',
>>>> 'advproxy wpad label dst_noproxy_ip' => 'Excluded IP Subnets (one per line)',
>>>> 'advproxy wpad label dst_noproxy_url' => 'Excluded URL s (one per line)',
>>>> -'advproxy wpad notice' => 'Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.',
>>>> +'advproxy wpad notice' => 'Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.',
>>>> 'advproxy wpad title' => 'Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)',
>>>> 'advproxy wpad view pac' => 'Open PAC File',
>>>> 'again' => 'Again:',
>>>> -- 
>>>> 2.33.0
>>>>
>