Re: [PATCH] speedtest-cli: Fix for bug #12602 - CORE 155 error with speedtest-cli

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 4024 bytes --]

Hello,

The user who reported this did not really make a case for why the client should be changed.

The Python client is working and still maintained, so I do not see any reason to change this.

-Michael

> On 8 Apr 2021, at 22:30, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Jon,
> 
> On 08/04/2021 23:10, Jon Murphy wrote:
>> I seem to remember a bug report for speedtest (besides #12602 below).  It had to do with this post:
>> https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698 <https://community.ipfire.org/t/replace-speedtest-cli-with-speedtest-for-better-accuracy/3698>
>> I could not locate the bugzilla post.
> That is because the poster never raised it as a bug.
>> Can speedtest be updated for this issue?
> I provided links to the addon creation process and how to submit a patch to the development list. He was going to build the patch for himself and then submit it to the development list for review. He never came back with a patch submission.
> 
> Regards,
> Adolf
>> Jon
>>> On Apr 8, 2021, at 3:37 PM, Adolf Belka <adolf.belka(a)ipfire.org <mailto:adolf.belka(a)ipfire.org>> wrote:
>>> 
>>> - Update from 2.1.2 to 2.1.3 - fix for bug #12602
>>>   Updated addon installed and fix confirmed
>>> - Update rootfile
>>> - Changelog
>>>    Address issue where a test server may return an HTTP error during upload or download
>>>    Address issue where ignore_ids may be empty or have empty values
>>> 
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org <mailto:adolf.belka(a)ipfire.org>>
>>> ---
>>> config/rootfiles/packages/speedtest-cli | 13 +++++++------
>>> lfs/speedtest-cli                       |  6 +++---
>>> 2 files changed, 10 insertions(+), 9 deletions(-)
>>> 
>>> diff --git a/config/rootfiles/packages/speedtest-cli b/config/rootfiles/packages/speedtest-cli
>>> index 0ef126e23..6632e235c 100644
>>> --- a/config/rootfiles/packages/speedtest-cli
>>> +++ b/config/rootfiles/packages/speedtest-cli
>>> @@ -1,9 +1,10 @@
>>> usr/bin/speedtest
>>> usr/bin/speedtest-cli
>>> usr/lib/python3.8/site-packages/speedtest.py
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/PKG-INFO
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/SOURCES.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/dependency_links.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/entry_points.txt
>>> -usr/lib/python3.8/site-packages/speedtest_cli-2.1.2-py3.8.egg-info/top_level.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/PKG-INFO
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/SOURCES.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/dependency_links.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/entry_points.txt
>>> +usr/lib/python3.8/site-packages/speedtest_cli-2.1.3-py3.8.egg-info/top_level.txt
>>> +
>>> diff --git a/lfs/speedtest-cli b/lfs/speedtest-cli
>>> index 446844ab3..f6bcf4c96 100644
>>> --- a/lfs/speedtest-cli
>>> +++ b/lfs/speedtest-cli
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 2.1.2
>>> +VER        = 2.1.3
>>> 
>>> THISAPP    = speedtest-cli-$(VER)
>>> DL_FILE    = $(THISAPP).tar.gz
>>> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
>>> DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>> TARGET     = $(DIR_INFO)/$(THISAPP)
>>> PROG       = speedtest-cli
>>> -PAK_VER    = 3
>>> +PAK_VER    = 4
>>> 
>>> DEPS       =
>>> 
>>> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = a49ad088331810fc9442e8a5c59de713
>>> +$(DL_FILE)_MD5 = 08c431f2f398880745c4f0564962b9e2
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.31.1
>>>