From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net
Date: Thu, 06 May 2021 16:08:06 +0100
Message-ID: <2D0B50FE-BFA0-42E4-9B61-AE122E268A90@ipfire.org>
In-Reply-To: <df52a137-57b8-31cd-77a4-37143fd559c8@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7163281498507511645=="
List-Id: <development.lists.ipfire.org>

--===============7163281498507511645==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Martin,

> On 6 May 2021, at 11:21, Martin Krieger <makrie(a)posteo.de> wrote:
>=20
> Hello Michael,
>=20
> by eMail again, because I didn't figure out to use git (commit, format-patc=
h & send-email) in the correct way for patch submission. Sorry.
>=20
> Regards,
>=20
> Martin Krieger
>=20
> diff --git a/README b/README
> index b6decb3..fa6ce5e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>        easydns.com
>        enom.com
>        entrydns.net
> +       feste-ip.net
>        freedns.afraid.org
>        inwx.com|de|at|ch|es
>        itsdns.de
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..c53ff9a 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>                # If we got here, some other update error happened.
>                raise DDNSUpdateError
>=20
> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
> +        handle    =3D "feste-ip.net"
> +        name      =3D "Feste-IP.Net"
> +        website   =3D "https://www.feste-ip.net/"
> +        protocols =3D ("ipv4","ipv6")

According to the documentation, the request has to be sent to a different hos=
t for IPv6. Just adding it to the list probably won=E2=80=99t work because th=
is provider has implemented a different way to use the DynDNS API.

> +        # Information about the format of the request is to be found
> +        # https://www.feste-ip.net/ddns-service/einrichtung/linux/
> +
> +        url =3D "https://members.feste-ip.net/nic/update"
>=20
> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>        handle    =3D "freedns.afraid.org"
>=20
> Michael Tremer:
>> Hello Martin,
>> Thank you very much for your submission.
>>> On 5 May 2021, at 19:13, Martin Krieger <makrie(a)posteo.de> wrote:
>>>=20
>>> diff --git a/README b/README
>>> index b6decb3..fa6ce5e 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
>>>        easydns.com
>>>        enom.com
>>>        entrydns.net
>>> +       feste-ip.net
>>>        freedns.afraid.org
>>>        inwx.com|de|at|ch|es
>>>        itsdns.de
>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>> index 56e6620..c70423b 100644
>>> --- a/src/ddns/providers.py
>>> +++ b/src/ddns/providers.py
>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider):
>>>                # If we got here, some other update error happened.
>>>                raise DDNSUpdateError
>>>=20
>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider):
>>> +        handle    =3D "feste-ip.net"
>>> +        name      =3D "Feste-IP.Net"
>>> +        website   =3D "https//www.feste-ip.net/"
>> You are missing a =E2=80=9C:=E2=80=9D in the URL.
>>> +        protocols =3D ("ipv4",)
>> According to this documentation, the provider supports IPv6 as well:
>>   https://www.feste-ip.net/ddns-service/einrichtung/linux/
>>> +        # Information about the format of the request is to be found
>>> +        # https://www.feste-ip.net/ddns-service/allgemeine-informationen/
>>> +
>>> +        url =3D "https://members.feste-ip.net/nic/update"
>>>=20
>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>        handle    =3D =E2=80=9Cfreedns.afraid.org"
>>>=20
>> Best,
>> -Michael
>=20


--===============7163281498507511645==--