Error message being shown from IPFire2.x build

Error message being shown from IPFire2.x build

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

Hi All,

Seems that the code that is checking if an architecture has been used in a rootfile is also looking at the Core Update update.sh file.


I just got this error message.

Error! 'aarch64' in rootfiles files found!
./config/rootfiles/core/185/update.sh:    aarch64)
Replace by xxxMACHINExxx !

The aarch64 use in update.sh makes sense as it is a command to only be run for aarch64 and not at all for x86_64.

It is not a big problem and can be ignored in this case but the check code probably should only look in the common and the packages rootfile directories and sub-directories.


Regards,

Adolf

Re: Error message being shown from IPFire2.x build

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Hello Adolf,

Yes, this is a false positive lol.

I will have a look and silence this.

-Michael

> On 14 Mar 2024, at 16:27, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi All,
> 
> Seems that the code that is checking if an architecture has been used in a rootfile is also looking at the Core Update update.sh file.
> 
> 
> I just got this error message.
> 
> Error! 'aarch64' in rootfiles files found!
> ./config/rootfiles/core/185/update.sh:    aarch64)
> Replace by xxxMACHINExxx !
> 
> The aarch64 use in update.sh makes sense as it is a command to only be run for aarch64 and not at all for x86_64.
> 
> It is not a big problem and can be ignored in this case but the check code probably should only look in the common and the packages rootfile directories and sub-directories.
> 
> 
> Regards,
> 
> Adolf
> 

Re: Error message being shown from IPFire2.x build

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

I rewrote the script:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=9820735b9ecc0e442d99a58b96e4309da4edeff6

Please let me know if that fixes the problem.

-Michael

> On 15 Mar 2024, at 10:28, Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> 
> Hello Adolf,
> 
> Yes, this is a false positive lol.
> 
> I will have a look and silence this.
> 
> -Michael
> 
>> On 14 Mar 2024, at 16:27, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>> 
>> Hi All,
>> 
>> Seems that the code that is checking if an architecture has been used in a rootfile is also looking at the Core Update update.sh file.
>> 
>> 
>> I just got this error message.
>> 
>> Error! 'aarch64' in rootfiles files found!
>> ./config/rootfiles/core/185/update.sh:    aarch64)
>> Replace by xxxMACHINExxx !
>> 
>> The aarch64 use in update.sh makes sense as it is a command to only be run for aarch64 and not at all for x86_64.
>> 
>> It is not a big problem and can be ignored in this case but the check code probably should only look in the common and the packages rootfile directories and sub-directories.
>> 
>> 
>> Regards,
>> 
>> Adolf
>> 
>