From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] backup.cgi: Read and deliver the requested backup in pieces
Date: Wed, 10 May 2023 11:11:45 +0100
Message-ID: <2DF4591F-5B75-4CEA-9801-42D74DE7E512@ipfire.org>
In-Reply-To: <20230510095203.2567-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8726385498215200632=="
List-Id: <development.lists.ipfire.org>

--===============8726385498215200632==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 10 May 2023, at 10:52, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Read-in the requested backup file line by line and directly deliver this
> as stream to the client.
>=20
> This fixes the problem with very big backups on systems with very
> limited RAM, which resulted in an OOM kill of the CGI and delivery
> process.
>=20
> Fixes #13096.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> html/cgi-bin/backup.cgi | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/backup.cgi b/html/cgi-bin/backup.cgi
> index 1c01cb286..3888ccbff 100644
> --- a/html/cgi-bin/backup.cgi
> +++ b/html/cgi-bin/backup.cgi
> @@ -366,6 +366,13 @@ sub deliver_file() {
>=20
> # Deliver content
> open(FILE, "<$file") or die "Unable to open $file: $!";
> - print <FILE>;
> +
> + # Read the file line by line and send it
> + # to the client.
> + while (<FILE>) {
> + print $_;
> + }
> +
> + # Close file handle.
> close(FILE);
> }
> --=20
> 2.30.2
>=20


--===============8726385498215200632==--