public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Revert "parse-func.pl: Adjust regular expression to changed 'tc' output"
Date: Thu, 22 Jun 2023 21:32:00 +0000	[thread overview]
Message-ID: <2bb73359-2a3d-2645-7bfb-864f261dfcfc@ipfire.org> (raw)
In-Reply-To: <20230622155115.1741-1-michael.tremer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2706 bytes --]

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> This reverts commit ca06e817b84b8bb737b2811bdc5ad43d034e2c48.
> 
> The incorrect output has been fixed in tc.
> 
> Fixes: #13150
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  config/qos/parse-func.pl | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/config/qos/parse-func.pl b/config/qos/parse-func.pl
> index 04ca85b7f..991757f92 100644
> --- a/config/qos/parse-func.pl
> +++ b/config/qos/parse-func.pl
> @@ -46,24 +46,24 @@ class htb 1:10 parent 1:1 prio 0 rate 80Kbit ceil 320Kbit burst 1701b cburst 200
>   lended: 230876 borrowed: 17112 giants: 0
>   tokens: 127200 ctokens: 37940
>  
> -class htb 1:20 parent 1:1 leaf 4220prio 1 rate 100Kbit ceil 200Kbit burst 1727b cburst 1855b 
> +class htb 1:20 parent 1:1 leaf 4220: prio 1 rate 100Kbit ceil 200Kbit burst 1727b cburst 1855b 
>   Sent 2495181573 bytes 44034303 pkts (dropped 5837, overlimits 0) 
>   lended: 43825585 borrowed: 208718 giants: 0
>   tokens: 103424 ctokens: 55808
>  
> -class htb 1:30 parent 1:1 leaf 4230prio 3 rate 80Kbit ceil 400Kbit burst 1701b cburst 2111b 
> +class htb 1:30 parent 1:1 leaf 4230: prio 3 rate 80Kbit ceil 400Kbit burst 1701b cburst 2111b 
>   Sent 2060213567 bytes 5465574 pkts (dropped 121, overlimits 0) 
>   rate 16851bps 35pps 
>   lended: 4556992 borrowed: 908582 giants: 0
>   tokens: -25364 ctokens: 32897
>  
> -class htb 1:50 parent 1:1 leaf 4250prio 5 rate 40Kbit ceil 120Kbit burst 1650b cburst 1752b 
> +class htb 1:50 parent 1:1 leaf 4250: prio 5 rate 40Kbit ceil 120Kbit burst 1650b cburst 1752b 
>   Sent 6071486687 bytes 24448436 pkts (dropped 8086739, overlimits 0) 
>   rate 15801bps 85pps backlog 126p 
>   lended: 8324530 borrowed: 16123780 giants: 0
>   tokens: -202717 ctokens: -172499
>  
> -class htb 1:666 parent 1:1 leaf 666prio 7 rate 4Kbit ceil 40Kbit burst 1604b cburst 1650b 
> +class htb 1:666 parent 1:1 leaf 666: prio 7 rate 4Kbit ceil 40Kbit burst 1604b cburst 1650b 
>   Sent 2148626078 bytes 6771069 pkts (dropped 2078536, overlimits 0) 
>   rate 5221bps 17pps backlog 125p 
>   lended: 675330 borrowed: 6095613 giants: 0
> @@ -94,7 +94,7 @@ sub parse_class($) {
>  	my $line=$tc_output[$i];
>  	# Parsing HTB:
>  	# ------------
> -	if ( $line =~ m/class htb (\d+):(\d+)( root| parent )?(\d+:\d+)?( leaf )?(\d+)?(prio )?(\d+)? rate (.*) ceil (.*) burst (.*) cburst (.*)/ ) {
> +	if ( $line =~ m/class htb (\d+):(\d+)( root| parent )?(\d+:\d+)?( leaf )?(\d+)?:?( prio )?(\d+)? rate (.*) ceil (.*) burst (.*) cburst (.*)/ ) {
>  	    my $type  = "htb";
>  	    my $major = $1;
>  	    my $minor = $2;

      reply	other threads:[~2023-06-22 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 15:51 Michael Tremer
2023-06-22 21:32 ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bb73359-2a3d-2645-7bfb-864f261dfcfc@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox