From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bS6xM6nXKz339D for ; Wed, 25 Jun 2025 16:40:07 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bS6xJ2pjtz2xLw for ; Wed, 25 Jun 2025 16:40:04 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4bS6xH5wgmzdr; Wed, 25 Jun 2025 16:40:03 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1750869603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5p2exwjsUosytJR2QQYtTlmNIDInpnoO6MOnxQTdCI=; b=YOhFRwiLobrh6mFrhUNECelz97Km3ww0d2AhGaBZrYN1amVLfSuZf/Adjtk155bPygxF7t CX55KWb6diMN4PCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1750869603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5p2exwjsUosytJR2QQYtTlmNIDInpnoO6MOnxQTdCI=; b=AHVnXewQeQMNoHbcftumCdOZlWPxeaajjuzOJAAlfxTFepC9mTUNTnbwXkQxgEthQ79Com bfch6QCnAgBdYgQdyvsdzlNlF6jKrWjAd/424At8IR1GdAzNfjdKweEB1sFbjh+WYRV7kU 2IlDOhFaCbtqKsR2SaW8RplYnMwgTmOCYCu5fr8eHJuJ09qStO9OQBdrpIBD4Fd+QqiYr6 jn0dE910FxeAlzUhNyC+mr2DCOuEqeyzurYUbRmBpKtPQQBwjyjaeadaR9LT6DH6+q0I42 vdxPdJTBOEvp8P7kmAfM/E4jNWYMB/YMcXLhvxvmMmmlBbpOX3mxMGEiu2DM9w== Message-ID: <2bf6ef30-c057-4d39-98d5-8ef4ea35edea@ipfire.org> Date: Wed, 25 Jun 2025 18:40:03 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH 4/5] fwhosts.cgi: Move the tooltip into the usage counter To: Michael Tremer References: <20250623171658.530138-1-michael.tremer@ipfire.org> <20250623171658.530138-4-michael.tremer@ipfire.org> Content-Language: en-GB Cc: "IPFire: Development-List" , dietzmann@brecht-schule.hamburg From: Adolf Belka In-Reply-To: <20250623171658.530138-4-michael.tremer@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Tested-by: Adolf Belka I actually found the i in a blue circle icon very helpful for this. I was able to figure out where I should place my mouse pointer for the info. With this patch applied, which was the first way I tested it, I had no idea where to place the mouse pointer as nothing looked different to the existing situation. I did try placing it over the usage counter a couple of times but obviously not for long enough in my first tries as I never saw anything get shown. Reading the title of this patch more carefully I went back and now held the mouse pointer over the usage counter and waited for 1 to 2 seconds and now the info was shown. Typically I found it takes a minimum of 1 second and sometimes around 1.5 seconds before anything is shown and first time around I was obviously not waiting long enough at any one location. If the usage counter is to stay as the location to place the mouse pointer onto for the info then I think this will need to be explained very clearly in the wiki documentation otherwise users might not discover this useful function directly on the WUI page. On 23/06/2025 19:16, Michael Tremer wrote: > This will clutter the page less as we don't have any good icon sets. > > Signed-off-by: Michael Tremer > --- > html/cgi-bin/fwhosts.cgi | 42 +++++++++++----------------------------- > 1 file changed, 11 insertions(+), 31 deletions(-) > > diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi > index 69970a840..953f81e5f 100644 > --- a/html/cgi-bin/fwhosts.cgi > +++ b/html/cgi-bin/fwhosts.cgi > @@ -1932,7 +1932,7 @@ sub viewtablenet > }else{ > print< > - > + > END > } > my $count=0; > @@ -1953,11 +1953,7 @@ END > my $colnet="$customnetwork{$key}[1]/".&General::subtocidr($customnetwork{$key}[2]); > my $netcount=&getnetcount($customnetwork{$key}[0]); > my $netusedin=&getusedin($customnetwork{$key}[0]); > - my $htmlparttouse=""; > - if ($netusedin) { > - $htmlparttouse = ""; > - } > - print""; > + print""; > print<
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost netaddress'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customnetwork{$key}[0]
".&getcolor($colnet)."$customnetwork{$key}[3]$netcount x$htmlparttouse$customnetwork{$key}[0]".&getcolor($colnet)."$customnetwork{$key}[3]$netcount x > > @@ -2091,7 +2087,7 @@ sub viewtablehost > }else{ > print< > - > + > END > } > my $count=0; > @@ -2112,12 +2108,9 @@ END > my $hostcount=0; > $hostcount=&gethostcount($customhost{$key}[0]); > my $hostusedin=&getusedin($customhost{$key}[0]); > - my $htmlparttouse=""; > - if ($hostusedin) { > - $htmlparttouse = ""; > - } > - print""; > - print< + my $color = &getcolor($ip); > + print < + >
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$Lang::tr{'name'}$Lang::tr{'fwhost ip_mac'}$Lang::tr{'remark'}$Lang::tr{'used'}
$customhost{$key}[0]".&getcolor($ip)."$customhost{$key}[3]$hostcount x$htmlparttouse$customhost{$key}[0]$color$customhost{$key}[3]$hostcount x > > > @@ -2192,11 +2185,8 @@ sub viewtablegrp > print "
$grpname   "; > print " $Lang::tr{'remark'}:  $remark   " if ($remark ne ''); > my $netgrpcount=&getnetcount($grpname); > - print "$Lang::tr{'used'}: $netgrpcount x "; > my $groupusedin=&getusedin($grpname); > - if ($groupusedin) { > - print ""; > - } > + print "$Lang::tr{'used'}: $netgrpcount x"; > if($netgrpcount == '0') > { > print""; > @@ -2335,10 +2325,7 @@ sub viewtablelocationgrp > # Get group count. > my $locationgrpcount=&getlocationcount($grpname); > my $locationusedin=&getlocusedin($grpname); > - print "$Lang::tr{'used'}: $locationgrpcount x "; > - if ($locationusedin) { > - print ""; > - } > + print "$Lang::tr{'used'}: $locationgrpcount x"; > # Only display delete icon, if the group is not used by a firewall rule. > if($locationgrpcount == '0') { > print"
\n"; > @@ -2459,7 +2446,7 @@ sub viewtableservice > &General::readhasharray("$fwconfigout", \%fwout); > print< > - > + > END > my $col=''; > foreach my $key (sort { ncmp($customservice{$a}[0],$customservice{$b}[0])} keys %customservice) > @@ -2481,14 +2468,10 @@ END > #Neuer count > $srvcount=&getsrvcount($customservice{$key}[0]); > my $serviceusedin=&getsrvusedin($customservice{$key}[0]); > - my $htmlparttouse=""; > - if ($serviceusedin) { > - $htmlparttouse=""; > - } > if($customservice{$key}[3] eq 'All ICMP-Types'){print $Lang::tr{'fwdfw all icmp'};} > elsif($customservice{$key}[3] ne 'BLANK'){print $customservice{$key}[3];} > print< - > + >
$Lang::tr{'fwhost srv_name'}$Lang::tr{'fwhost prot'}$Lang::tr{'fwhost port'}ICMP$Lang::tr{'fwhost used'}
$Lang::tr{'fwhost srv_name'}$Lang::tr{'fwhost prot'}$Lang::tr{'fwhost port'}ICMP$Lang::tr{'fwhost used'}
$srvcount x$htmlparttouse$srvcount x > > > @@ -2560,11 +2543,8 @@ sub viewtableservicegrp > if($count >0){print"
";$count=1;} > print "
$grpname    "; > print "$Lang::tr{'remark'}:  $remark " if ($remark ne ''); > - print "  $Lang::tr{'used'}: $grpcount x "; > my $srvgrpusedin=&getsrvusedin($customservicegrp{$key}[0]); > - if ($srvgrpusedin) { > - print ""; > - } > + print "  $Lang::tr{'used'}: $grpcount x"; > if($grpcount == '0') > { > print"";