[PATCH] ovpnmain.cgi: Show only IP for Real Address in Connection Statistics page

[PATCH] ovpnmain.cgi: Show only IP for Real Address in Connection Statistics page

[Adolf Belka]

- IP:Port was being shown rather than IP alone. The status was being split but not copied
   back into the variable that is then shown on the status page.
- Tested on my vm system. The status page changed from showing IP:Port to only IP for
   Real Address.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 html/cgi-bin/ovpnmain.cgi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index ec86a218b..814499d21 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -2,7 +2,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2023  IPFire Team  <info@ipfire.org>                     #
+# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -3178,6 +3178,7 @@ END
 			$users[$uid]{'Since'} = $match[5];
 
 			my $address = (split ':', $users[$uid]{'RealAddress'})[0];
+			$users[$uid]{'RealAddress'} = $address;
 			$users[$uid]{'Country'} = &Location::Functions::lookup_country_code($address);
 			$uid++;
 
-- 
2.51.2

Re: [PATCH] ovpnmain.cgi: Show only IP for Real Address in Connection Statistics page

[Adolf Belka]

Hi Michael,

I realised that my patch below had not been dealt with. Was it just missed? If it is okay, do I need to resubmit the patch with the time period that has gone past?

Regards,

Adolf.

On 06/11/2025 13:52, Adolf Belka wrote:
> - IP:Port was being shown rather than IP alone. The status was being split but not copied
>     back into the variable that is then shown on the status page.
> - Tested on my vm system. The status page changed from showing IP:Port to only IP for
>     Real Address.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
>   html/cgi-bin/ovpnmain.cgi | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index ec86a218b..814499d21 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2,7 +2,7 @@
>   ###############################################################################
>   #                                                                             #
>   # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2023  IPFire Team  <info@ipfire.org>                     #
> +# Copyright (C) 2007-2025  IPFire Team  <info@ipfire.org>                     #
>   #                                                                             #
>   # This program is free software: you can redistribute it and/or modify        #
>   # it under the terms of the GNU General Public License as published by        #
> @@ -3178,6 +3178,7 @@ END
>   			$users[$uid]{'Since'} = $match[5];
>   
>   			my $address = (split ':', $users[$uid]{'RealAddress'})[0];
> +			$users[$uid]{'RealAddress'} = $address;
>   			$users[$uid]{'Country'} = &Location::Functions::lookup_country_code($address);
>   			$uid++;
>