From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4f27sk31wBz2yBj for ; Thu, 29 Jan 2026 19:06:34 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [IPv6:2001:678:b28::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1 raw public key) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R12" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4f27sf6xQFz2xRF for ; Thu, 29 Jan 2026 19:06:30 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4f27sd5yDkz2CH for ; Thu, 29 Jan 2026 19:06:29 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1769713589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjucP4CzO/du2IYys1rbsI28gVAwxj/M6E5q7rigH3k=; b=TjdgXp0/Yu6096AIiDFwCE7HY/TtkdN/9g4sPG6ZwoYbfwWlRSGy/1i/I6tkFEnnvWsuQ0 jzMdaWDdkdo1gTCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1769713589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjucP4CzO/du2IYys1rbsI28gVAwxj/M6E5q7rigH3k=; b=MDcwOa8d+hOEbXkouM3dVnETCsuFat70xZBAtPTRL256bgFoRw6sLdL8rjC2eFWbI5v69n k8Ttl3Z6GdZ/FCvD/+vr2eYl3NCfsgWVA9MV+xvL+JAtfg/EYyHgF6Z50W92TSuqSDFeJH ixjrWcK2S72A/ej01dUO14mToppCbLgsx3aSYZ0b1C5SsqlmTkNWmDbMLzlzsCA/DYw6JV e/8gbqqb6y8spmVhG48Mm/4OYw7OIgQ3CWwbiDz0MleLbptxE1njyuEeiqNcgS8EjHq2kZ JR1fWbaDDMZjZfOKVv2X/CiUFq50Qw0W7BcQqv+4ZEIpFC2jVekyjsjcPKWKKg== Message-ID: <2c0a0241-8a4a-43a7-833c-6cf4f7b87c3c@ipfire.org> Date: Thu, 29 Jan 2026 20:06:26 +0100 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH] ovpnmain.cgi: Show only IP for Real Address in Connection Statistics page To: development@lists.ipfire.org References: <20251106125225.85685-1-adolf.belka@ipfire.org> Content-Language: en-GB From: Adolf Belka In-Reply-To: <20251106125225.85685-1-adolf.belka@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, I realised that my patch below had not been dealt with. Was it just missed? If it is okay, do I need to resubmit the patch with the time period that has gone past? Regards, Adolf. On 06/11/2025 13:52, Adolf Belka wrote: > - IP:Port was being shown rather than IP alone. The status was being split but not copied > back into the variable that is then shown on the status page. > - Tested on my vm system. The status page changed from showing IP:Port to only IP for > Real Address. > > Tested-by: Adolf Belka > Signed-off-by: Adolf Belka > --- > html/cgi-bin/ovpnmain.cgi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi > index ec86a218b..814499d21 100644 > --- a/html/cgi-bin/ovpnmain.cgi > +++ b/html/cgi-bin/ovpnmain.cgi > @@ -2,7 +2,7 @@ > ############################################################################### > # # > # IPFire.org - A linux based firewall # > -# Copyright (C) 2007-2023 IPFire Team # > +# Copyright (C) 2007-2025 IPFire Team # > # # > # This program is free software: you can redistribute it and/or modify # > # it under the terms of the GNU General Public License as published by # > @@ -3178,6 +3178,7 @@ END > $users[$uid]{'Since'} = $match[5]; > > my $address = (split ':', $users[$uid]{'RealAddress'})[0]; > + $users[$uid]{'RealAddress'} = $address; > $users[$uid]{'Country'} = &Location::Functions::lookup_country_code($address); > $uid++; >