Re: IPCop Banish Addon for IPFire

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2516 bytes --]

Hi,

On 07.01.2019 13:38, Bob Brewer wrote:
> Bob Brewer wrote:
> 
>> Matthias Fischer wrote:
>>> ...
>>> But the install script has a problem:

>>> ...

>> Ahhh... I made a late change to the init system and thought I had tested
>> it out ok on my test system here before I uploaded it.
>> 
>> Thank you for the feedback, I'll create a corrected 0.2 version and upload
>> it to github.
>> 
> 
> Looking closer line 170 should have been:
> 
>  /bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/rc.banish
> 
> then the symlinks would be OK
> ...

Some findings:

1. For keeping the "naming conventions" in '/etc/init.d', I'd suggest to
name this script just 'banish', not 'rc.banish'. This way it can be
found more easily. Every other script in this dir is named accordingly
to the program its starting/stopping...

2. With '1.0.2', installation throws no errors anymore, but I can't add
any IP-Addresses. List stays empty. And everytime 'BanishGeo.cgi' is
opened, '/var/log/httpd/error_log' says:

***SNIP***
...
Usage: host [-aCdilrTvVw] [-c class] [-N ndots] [-t type] [-W time]
            [-R number] [-m flag] hostname [server]
       -a is equivalent to -v -t ANY
       -c specifies query class for non-IN data
       -C compares SOA records on authoritative nameservers
       -d is equivalent to -v
       -i IP6.INT reverse lookups
       -l lists all hosts in a domain, using AXFR
       -m set memory debugging flag (trace|record|usage)
       -N changes the number of dots allowed before root lookup is done
       -r disables recursive processing
       -R specifies number of retries for UDP packets
       -s a SERVFAIL response should stop query
       -t specifies the query type
       -T enables TCP/IP mode
       -v enables verbose output
       -V print version number and exit
       -w specifies to wait forever for a reply
       -W specifies how long to wait for a reply
       -4 use IPv4 query transport only
       -6 use IPv6 query transport only
...
***SNAP**

It seems there are some syntax errors in 'BanishGeo.cgi' (line 773!?).

3. $Lang::tr{'apply'} - used in 'BanishGeo.cgi' line 232 - is missing in
the language-files.

4. Uninstaller didn't remove '/var/ipfire/menu.d/EX-banish.menu' and
'EX-Banishlog.menu'. They're not shown anymore, but files are still there.

5. None of the given URLs is working here:
http://wiki.sidsolutions.net/ => "Can't be found".
http://banish.sidsolutions.net
is redirected to
ww2.banish.sidsolutions.net => no answer...

HTH,
Matthias