From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] Nano: Move nano editor from packages to core system Date: Mon, 21 Mar 2022 19:06:31 +0000 Message-ID: <2cd3278b-bbee-c1fd-5790-4732cc12fe2f@ipfire.org> In-Reply-To: <1851154E-3D7A-4E87-B3DF-7BFFD339D49A@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7555331691857647279==" List-Id: --===============7555331691857647279== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello *, I just merged this patch into next, but since it was generated manually, I ha= d to do the changes introduced by it myself manually. > Hello, >=20 > I personally do not count nano as an editor. There are so many things wrong= with it :) >=20 > But if everyone wants this, I do not think that shipping ~444 KB of code wi= ll break the camel=E2=80=99s back. Certainly not. >=20 > Acked-by: Michael Tremer >=20 > -Michael >=20 > P.S. @Peter: Would you please make sure that pakfire drops the metadata of = the package? Yes. Thanks, and best regards, Peter M=C3=BCller >=20 >> On 21 Mar 2022, at 17:49, Adolf Belka wrote: >> >> Hi All, >> >> On 21/03/2022 17:22, Peter M=C3=BCller wrote: >>> Hello *, >>> >>>> Hello, >>>> >>>> How is everybody feeling about this? >>> I understand the motivation behind this. In my early days, I completely l= acked any vim >>> skills, and found it pretty stressing to bring things back up after a cra= sh while at the >>> same time frantically thinking "how to %&=C2=A7#$ deal with this text edi= tor?!". >>> >>>> How many nano users do we have here? >> I am definitely one. I also use nano for working on my Arch Linux systems = and adjust the default editor for things like visudo so it uses nano. >> >> >> Regards, >> Adolf. >>> Back then, nano would have helped me. Today, I am used to vim and would n= ot experience >>> any benefit from nano being around on IPFire as well. >>> >>> Nevertheless, I vote in favour of this patch, for reasons mentioned above. >>> >>> Acked-by: Peter M=C3=BCller >>> >>> Thanks, and best regards, >>> Peter M=C3=BCller >>> >>>> -Michael >>>> >>>>> On 17 Mar 2022, at 17:06, Jon Murphy wrote: >>>>> >>>>> - this will not change the default editor `vim` >>>>> >>>>> Signed-off-by: Jon Murphy >>>>> --- >>>>> config/rootfiles/{packages =3D> common}/nano | 0 >>>>> lfs/nano | 7 +++---- >>>>> 2 files changed, 3 insertions(+), 4 deletions(-) >>>>> rename config/rootfiles/{packages =3D> common}/nano (100%) >>>>> >>>>> diff --git a/config/rootfiles/packages/nano b/config/rootfiles/common/n= ano >>>>> similarity index 100% >>>>> rename from config/rootfiles/packages/nano >>>>> rename to config/rootfiles/common/nano >>>>> diff --git a/lfs/nano b/lfs/nano >>>>> index df994364f..85be014ee 100644 >>>>> --- a/lfs/nano >>>>> +++ b/lfs/nano >>>>> @@ -32,12 +32,11 @@ DL_FILE =3D $(THISAPP).tar.xz >>>>> DL_FROM =3D $(URL_IPFIRE) >>>>> DIR_APP =3D $(DIR_SRC)/$(THISAPP) >>>>> TARGET =3D $(DIR_INFO)/$(THISAPP) >>>>> -PROG =3D nano >>>>> -PAK_VER =3D 41 >>>>> >>>>> -DEPS =3D "" >>>>> >>>>> -SERVICES =3D >>>>> >>>>> #######################################################################= ######## >>>>> # Top-level Rules >>>>> --=20 >>>>> 2.30.2 >>>>> >> >> --=20 >> Sent from my laptop >=20 --===============7555331691857647279==--