public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: ''backup.cgi' - new icons - new order - query for delete / translation strings
Date: Sat, 24 Nov 2018 22:38:53 +0100	[thread overview]
Message-ID: <2d78f94c-7133-566c-e823-28b7f29adedb@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

Hi,

Something similar has been posted before ([PATCH] Cosmetics: New icons
for backup.cgi), but unfortunately the discussion was not continued for
very long.

Triggered by:

https://forum.ipfire.org/viewtopic.php?f=17&t=21372

and

https://forum.ipfire.org/viewtopic.php?f=17&t=21882

I'd like to know whether there is any interest in developing this any
further. In the meantime, patches were built for 'backup.cgi' which not
only update the icons and their order of precedence for better
readability and usability. In an additional step, the 'delete' icons got
'onclick'-confirmation boxes (by Erik!) to prevent accidental deletions.

Another step could be to add this confirmation to other CGIs. This
additional query could prevent some trouble in the future as it happened
to the original poster of the second link above. He accidentally deleted
an OVPN client. No query... I'm already testing this functionality in
other contexts (e.g., firewall rules, dhcp, hosts) and it works.

And the last question: each current lang file contains up to ~600 unused
translation strings. These are summing up to about 5000 strings which
are not used or duplicates and could be deleted. Current size of all
lang files is 1.2MB - we actually need about 900KB. A current patch can
be found here:

https://git.ipfire.org/?p=people/ummeegge/ipfire-2.x.git;a=commit;h=acbf3208e4a0d61c138d38326079a29b97545007

At the beginning of this year I built some patches for these unused
strings and some other corrections
(https://patchwork.ipfire.org/patch/1605/) but sadly got no reaction at
all. Is there any interest, should we re-edit the unused translations?

What do you think? Opinions and comments are welcome...

Best,
Matthias

             reply	other threads:[~2018-11-24 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 21:38 Matthias Fischer [this message]
2018-11-25 13:30 ` Tom Rymes
2018-12-04 13:55   ` ummeegge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d78f94c-7133-566c-e823-28b7f29adedb@ipfire.org \
    --to=matthias.fischer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox