From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] proxy.cgi: Some cosmetics for the absolutely lazy ones... ; -)
Date: Thu, 21 Sep 2017 00:40:02 +0200 [thread overview]
Message-ID: <2ec3566d-2019-7e5c-51be-6adf0efcadc2@ipfire.org> (raw)
In-Reply-To: <1505942554.4381.20.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
Hi,
On 20.09.2017 23:22, Michael Tremer wrote:
> it would be way better to have the link in the CGI and not in the
> translation file. That way translators wouldn't have to deal with any
> of the markup and what is even worse: being able to inject any kind of
> HTML into the generated output. But that is a different issue.
Yep. Why did I know that you would answer that...? ;-))
> Would you be up for sending a corrected patch?
No problem - I'll try, but the first attempts ended in a blank page.
I tried to add these links like in 'wlanap.cgi' (lines 536ff) but hadn't
so far no luck, only a white "server error" page. I'll try again.
> I like the idea to get a reference so people find the correct
> configuration page easily.
Me, too - and the easiest way I remembered was the way we did this in
Copfilter. However not the best way.
Best,
Matthias
prev parent reply other threads:[~2017-09-20 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 13:18 Matthias Fischer
2017-09-20 21:22 ` Michael Tremer
2017-09-20 22:40 ` Matthias Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec3566d-2019-7e5c-51be-6adf0efcadc2@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox