From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] proxy.cgi: Some cosmetics for the absolutely lazy ones... ; -)
Date: Thu, 21 Sep 2017 00:40:02 +0200
Message-ID: <2ec3566d-2019-7e5c-51be-6adf0efcadc2@ipfire.org>
In-Reply-To: <1505942554.4381.20.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5623847529100320908=="
List-Id: <development.lists.ipfire.org>

--===============5623847529100320908==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi,

On 20.09.2017 23:22, Michael Tremer wrote:

> it would be way better to have the link in the CGI and not in the
> translation file. That way translators wouldn't have to deal with any
> of the markup and what is even worse: being able to inject any kind of
> HTML into the generated output. But that is a different issue.

Yep. Why did I know that you would answer that...? ;-))

> Would you be up for sending a corrected patch?

No problem - I'll try, but the first attempts ended in a blank page.

I tried to add these links like in 'wlanap.cgi' (lines 536ff) but hadn't
so far no luck, only a white "server error" page. I'll try again.

> I like the idea to get a reference so people find the correct
> configuration page easily.

Me, too - and the easiest way I remembered was the way we did this in
Copfilter. However not the best way.

Best,
Matthias

--===============5623847529100320908==--