From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: libnfnetlink and libmnl Date: Thu, 07 Apr 2022 17:43:12 +0200 Message-ID: <302e0bee-222a-a61d-1faa-7cf2c39c840b@ipfire.org> In-Reply-To: <8CE7430A-0250-4827-B68B-DACCBAB57A71@rymes.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0405954607029504974==" List-Id: --===============0405954607029504974== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Tom, On 07/04/2022 17:37, Tom Rymes wrote: > Adolf, >=20 > Is sdparm and/or lvm2 used by the =E2=80=9Cextra HD=E2=80=9D addon? It didn't show up with a grep of the IPFire git repository. I will have a fur= ther look into it to see if they are needed to run it. Regards, Adolf. >=20 > Tom >=20 >> On Apr 7, 2022, at 7:19 AM, Adolf Belka wrote: >> >> =EF=BB=BFHi Michael & *, >> >> Building without >> >> libart >> libdnet >> libpri >> libsolv >> pigz >> sdparm >> >> went without any problems. I have submitted a patch set removing them from= IPFire. >> >> libnet needs to stay as arping requires it. >> >> libaio is needed by lvm2. However when I looked at lvm2 in IPFire it is no= t actually used by IPFire at all. The commands are all available but there ar= e no mapped volume groups , logical groups etc. >> Is lvm2 provided so that people can use logical volumes on additional hard= disks that might be mounted on IPFire. Presumably if people have already cre= ated lvm structures on other disk drives on the IPFire hardware then we need = to stay with lvm2 being present otherwise its removal would stop people being= able to access that additional hard disk(s). >> If that is the case then libaio will also need to stay. >> >> Regards, >> Adolf. >> >>> On 06/04/2022 19:02, Michael Tremer wrote: >>> Hello, >>>>> On 6 Apr 2022, at 17:52, Adolf Belka wrote: >>>> >>>> Hi Michael, >>>> >>>> On 06/04/2022 17:38, Adolf Belka wrote: >>>>> Hi Michael, >>>>> >>>>> On 06/04/2022 16:42, Michael Tremer wrote: >>>>>> Hello Adolf, >>>>>> >>>>>>> On 6 Apr 2022, at 14:18, Adolf Belka wrote: >>>>>>> >>>>>>> Hi All, >>>>>>> >>>>>>> We have both libnfnetlink and libmnl in IPFire. I have just done an u= pdate of libmnl. >>>>>>> There is an update of libnfnetlink but it also says that libnfnetlink= is still deprecated and should preferably be replaced by libmnl >>>>>> >>>>>> Oh this is very interesting. >>>>>> >>>>>> It looks like libmnl was introduced for conntrack-tools in this commit: >>>>>> >>>>>> commit a10733a5d8580b6ab8cff46235daab6547723781 >>>>>> Author: Arne Fitzenreiter >>>>>> Date: Thu Jan 3 14:27:11 2013 +0100 >>>>>> >>>>>> conntrack-tools: add conntrack and needed deps. >>>>>> >>>>>> You can try to comment out libnfnetlink and libmnl and run a clean bui= ld and see if it goes through. If so, then we can safely drop them. >>>>>> >>>> It didn't go clean. It looks like libnetfilter_queue requires both libmn= l and libnfnetlink for compiling/building different parts of libnetfilter_que= ue. I don't know if it is required for running but it wouldn't surprise me so= both these will have to stay. >>>> >>>> It's interesting that the group that says libmnl should be used in prefe= rence to libnfnetlink then go and require both to still be used for one of th= eir programs. >>> Well, we all have good intentions to keep our software clean, but very of= ten there is some legacy bit that everyone relies on and simply never gets cl= eaned up. >>>> I will continue looking through other files that you highlighted. >>> Thank you. >>>> >>>> >>>> Regards, >>>> >>>> Adolf. >>>> >>>>>>> I have run ./make.sh find-dependencies on both libmnl.so.0.2.0 and li= bnfnetlink.so.0.2.0 and neither came up with anything. Doing a grep on the gi= t repository for mnl or nfnetlink also didn't indicate anything using these. >>>>>>> How are they being used and what needs to be done to change the usage= of libnfnetlink to libmnl? >>>>>> >>>>>> See above. >>>>>> >>>>>> I believe there are a couple of other candidates for this which we sho= uld have a look at. There is libdnet that I noticed a little while ago, but I= am sure there will be plenty more when looking through the package list: >>>>>> >>>>>> libaio >>>>>> libart >>>>>> libnet >>>>>> libnl (and if something depends on it, can it not use libnl-3?) >>>>>> libpri (if I remember correctly this was a dependency of asterisk) >>>>>> libsolv can absolutely go for the moment, we don=E2=80=99t need it >>>>>> netpbm? >>>>>> pigz (we don=E2=80=99t use it anywhere since we are compressing images= with XZ b302b9a695e391477eab0cb2343f3ba1b1ba1989) >>>>>> sdparm >>>>>> >>>>>> If you have the time, maybe you can have a look at what is used somewh= ere and what can be dropped? >>>>> I will give that a go and use your inputs as starting points. >>>>> >>>>> Regards, >>>>> Adolf >>>>>> >>>>>> This won=E2=80=99t shrink the distribution by a massive amount, but wh= y should we carry around dead code? >>>>>> >>>>>> Best, >>>>>> -Michael >>>>>> >>>>>>> Regards, >>>>>>> Adolf --===============0405954607029504974==--