From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] dhcpcd: Update to version 10.0.1
Date: Fri, 02 Jun 2023 12:33:04 +0200
Message-ID: <30d6cb54-ae1d-7579-23d7-1df0a13893ea@ipfire.org>
In-Reply-To: <13B08A79-7B6E-44EA-A52E-DF2E71224B2D@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2435266314702839958=="
List-Id: <development.lists.ipfire.org>

--===============2435266314702839958==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On 02/06/2023 11:01, Michael Tremer wrote:
> Hello Adolf,
>=20
> Why do we need to disable the privilege separation feature here?
It doesn't but I suspected that some changes would be needed to the=20
config file to actually use it and as I don't know what would need to be=20
changed if I built it with privilege separation then it might not work=20
anymore.

If it is relatively easy to set privilege separation up and someone can=20
tell me what changes I need to make in the config file and/or elsewhere=20
then I can do a v2 version of the patch, also testing it out to confirm=20
it works.

Regards,
Adolf.
>=20
> -Michael
>=20
>> On 19 May 2023, at 12:47, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - Update from version 9.4.1 to 10.0.1
>> - Update of rootfile not required
>> - Tested on vm testbed and confirmed that dhcpcd worked as expected. Conne=
ction on red
>>    successfully made.
>> - Changelog is no longer provided. For details of changes you have to look=
 at the commits
>>    log - https://github.com/NetworkConfiguration/dhcpcd/commits
>>
>> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> lfs/dhcpcd                                            | 11 ++++++-----
>> ...0.1-Allow-free-selection-of-MTU-by-the-user.patch} |  0
>> 2 files changed, 6 insertions(+), 5 deletions(-)
>> rename src/patches/{dhcpcd-9.4.0-Allow-free-selection-of-MTU-by-the-user.p=
atch =3D> dhcpcd-10.0.1-Allow-free-selection-of-MTU-by-the-user.patch} (100%)
>>
>> diff --git a/lfs/dhcpcd b/lfs/dhcpcd
>> index 2373198da..ae1b75053 100644
>> --- a/lfs/dhcpcd
>> +++ b/lfs/dhcpcd
>> @@ -1,7 +1,7 @@
>> ##########################################################################=
#####
>> #                                                                         =
    #
>> # IPFire.org - A linux based firewall                                     =
    #
>> -# Copyright (C) 2007-2021  IPFire Team  <info(a)ipfire.org>              =
       #
>> +# Copyright (C) 2007-2023  IPFire Team  <info(a)ipfire.org>              =
       #
>> #                                                                         =
    #
>> # This program is free software: you can redistribute it and/or modify    =
    #
>> # it under the terms of the GNU General Public License as published by    =
    #
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER        =3D 9.4.1
>> +VER        =3D 10.0.1
>>
>> THISAPP    =3D dhcpcd-$(VER)
>> DL_FILE    =3D $(THISAPP).tar.xz
>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>
>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_BLAKE2 =3D 847c7451918ac89fe384e180ec52ee4624c0f2dc73354ecb4c6=
3b02d8d9cf0a6d164b33e5d083a05d4868079dcf6208a820b4263c80337a12be40a27517ecf87
>> +$(DL_FILE)_BLAKE2 =3D f1e93285d040b98bede86bb2e87e372afc0d1d124e7a6580c23=
d8d228a34ee17001fc3c2d9091b16fb082fe2f2ad7ba50c0dd7b0db2b2237ab1cff9ca152100a
>>
>> install : $(TARGET)
>>
>> @@ -70,13 +70,14 @@ $(subst %,%_BLAKE2,$(objects)) :
>> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>> @$(PREBUILD)
>> @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
>> - cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/dhcpcd-9.4.0-Allow-=
free-selection-of-MTU-by-the-user.patch
>> + cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/dhcpcd-10.0.1-Allow=
-free-selection-of-MTU-by-the-user.patch
>> cd $(DIR_APP) && ./configure \
>> --prefix=3D"" \
>> --sysconfdir=3D/var/ipfire/dhcpc \
>> --dbdir=3D/var/ipfire/dhcpc \
>> --libexecdir=3D/var/ipfire/dhcpc \
>> - --mandir=3D/usr/share/man
>> + --mandir=3D/usr/share/man \
>> + --disable-privsep
>> cd $(DIR_APP) && make $(MAKETUNING)
>> cd $(DIR_APP) && make install
>>
>> diff --git a/src/patches/dhcpcd-9.4.0-Allow-free-selection-of-MTU-by-the-u=
ser.patch b/src/patches/dhcpcd-10.0.1-Allow-free-selection-of-MTU-by-the-user=
.patch
>> similarity index 100%
>> rename from src/patches/dhcpcd-9.4.0-Allow-free-selection-of-MTU-by-the-us=
er.patch
>> rename to src/patches/dhcpcd-10.0.1-Allow-free-selection-of-MTU-by-the-use=
r.patch
>> --=20
>> 2.40.1
>>
>=20

--=20
Sent from my laptop

--===============2435266314702839958==--