From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 15/21] linux: Compress the kernel, modules and firmware
 using Zstandard
Date: Tue, 27 Dec 2022 12:26:35 +0100
Message-ID: <32D65501-396D-46C7-9333-68E6960D46CE@ipfire.org>
In-Reply-To: <ee0fc737-1aad-5039-ef88-fb43ebe7a164@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1235952677054399009=="
List-Id: <development.lists.ipfire.org>

--===============1235952677054399009==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I disagree for reasons that I pointed out in the cover letter.

Xz is probably doing a fine job here.

If other people think we have enough space, I obviously don=E2=80=99t have a =
problem at all with Zstandard.

> On 26 Dec 2022, at 20:29, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Zstandard is an ideal compression algorithm with great performance for
> this purpose. The kernel is still able to load firmware compressed using
> XZ and ramdisks compressed with various other algorirthms.
>=20
> Backported from IPFire 3.x as a3776d8aee67369dcff8ea091bc8b785dc2d6647.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.x86_64-ipfire | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index 085005dbc..763c7c842 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -41,10 +41,10 @@ CONFIG_HAVE_KERNEL_ZSTD=3Dy
> # CONFIG_KERNEL_GZIP is not set
> # CONFIG_KERNEL_BZIP2 is not set
> # CONFIG_KERNEL_LZMA is not set
> -CONFIG_KERNEL_XZ=3Dy
> +# CONFIG_KERNEL_XZ is not set
> # CONFIG_KERNEL_LZO is not set
> # CONFIG_KERNEL_LZ4 is not set
> -# CONFIG_KERNEL_ZSTD is not set
> +CONFIG_KERNEL_ZSTD=3Dy
> CONFIG_DEFAULT_INIT=3D""
> CONFIG_DEFAULT_HOSTNAME=3D"(none)"
> CONFIG_SWAP=3Dy
> @@ -807,8 +807,8 @@ CONFIG_MODULE_SIG_SHA512=3Dy
> CONFIG_MODULE_SIG_HASH=3D"sha512"
> # CONFIG_MODULE_COMPRESS_NONE is not set
> # CONFIG_MODULE_COMPRESS_GZIP is not set
> -CONFIG_MODULE_COMPRESS_XZ=3Dy
> -# CONFIG_MODULE_COMPRESS_ZSTD is not set
> +# CONFIG_MODULE_COMPRESS_XZ is not set
> +CONFIG_MODULE_COMPRESS_ZSTD=3Dy
> # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set
> CONFIG_MODPROBE_PATH=3D"/sbin/modprobe"
> # CONFIG_TRIM_UNUSED_KSYMS is not set
> --=20
> 2.35.3


--===============1235952677054399009==--