public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/4] Tor: Use crypto hardware acceleration if available
Date: Mon, 04 Oct 2021 10:49:33 +0000	[thread overview]
Message-ID: <32b28612-0d1b-40f2-6ec7-585b49c186d2@ipfire.org> (raw)
In-Reply-To: <5438800B-3D00-4F77-9359-99332D90E85B@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

Hello Michael,

thanks for your reply.

To quote from Tor's manpage (see https://2019.www.torproject.org/docs/tor-manual.html.en#HardwareAccel
for an online version of it):

>        HardwareAccel 0|1
>            If non-zero, try to use built-in (static) crypto hardware
>            acceleration when available. Can not be changed while tor is
>            running. (Default: 0)

Even if it is available, Tor does not use hardware crypto acceleration by default. While I consider
this a reasonable default for Tor users not trusting their hardware, we agreed on doing so a while
ago (https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=13eab1060d0474ddf413386de0361e32113f8cb7).

Therefore, this needs to be enabled explicitly, which is what this patch is good for. :-)

I hope to have your question answered.

Thanks, and best regards,
Peter Müller


> Hello,
> 
> Can you elaborate a little bit more on this?
> 
> Tor is using OpenSSL which by default should use RDRAND, AES-NI (if applicable) and so on.
> 
> What does this option change?
> 
> -Michael
> 
>> On 25 Sep 2021, at 08:08, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>> ---
>> html/cgi-bin/tor.cgi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/html/cgi-bin/tor.cgi b/html/cgi-bin/tor.cgi
>> index ce579aec1..2b0d93336 100644
>> --- a/html/cgi-bin/tor.cgi
>> +++ b/html/cgi-bin/tor.cgi
>> @@ -731,6 +731,7 @@ sub BuildConfiguration() {
>>
>> 	# Global settings.
>> 	print FILE "Sandbox 1\n";
>> +	print FILE "HardwareAccel 1\n";
>> 	print FILE "ControlPort $TOR_CONTROL_PORT\n";
>>
>> 	if ($settings{'TOR_ENABLED'} eq 'on') {
>> -- 
>> 2.26.2
> 

  reply	other threads:[~2021-10-04 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  7:07 [PATCH 1/4] Tor: Enable syscall sandbox Peter Müller
2021-09-25  7:08 ` [PATCH 2/4] Tor: Use crypto hardware acceleration if available Peter Müller
2021-09-25  7:08   ` [PATCH 3/4] Tor: Do not try to support IPv6 for Directory and OR ports Peter Müller
2021-09-25  7:09     ` [PATCH 4/4] Tor: Bump package version Peter Müller
2021-09-27 18:46   ` [PATCH 2/4] Tor: Use crypto hardware acceleration if available Michael Tremer
2021-10-04 10:49     ` Peter Müller [this message]
2021-10-04 13:59       ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32b28612-0d1b-40f2-6ec7-585b49c186d2@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox