Re: [PATCH 3/3] perl-Net-SMTP-SSL: Update to 1.04

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3789 bytes --]

Hey,

> On 22 Mar 2021, at 11:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 22/03/2021 12:19, Michael Tremer wrote:
>> Hello,
>> I merged it, because we need Git for development purposes.
>> I am writing CGI scripts on the systems and commit small changes. Copying files back and forth would be error-prone and waste time.
> That makes it clear what git is being used for. I am definitely following the copying files back and forth approach when I am working on some of the bugs and have found sometimes that I have had to start all over again because of errors. Makes sense to use git for managing that for the development work.

I love git. I am getting confused if I am editing files that are not part of a Git repository :)

>> I do not think that Git needs documentation on the wiki. There is some stuff in the development section.
> Understand. It's not intended for the general user but for development work.

Yes :)

>> If we can replace this module by a newer version, that would definitely help in the future :)
> I will see if I can give it a go but that will probably need to be tested well by you and the other devs to make sure it still does what you need it to do.

Breaking Git is not the worst because it won’t affect regular users. Obviously we need to test, but we should be able to find out very quickly if it works or not.

Best,
-Michael

> 
> Regards,
> Adolf.
>> -Michael
>>> On 22 Mar 2021, at 07:44, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi All,
>>> 
>>> When updating this dependency of git I saw that it was now deprecated. I had a look at the replacement library and while I could create it as a new addon, it was not clear to me if just defining it as a dependency of git would make git correctly use it.
>>> 
>>> I am also not sure why anyone would want to run git on a firewall. This addon is not listed in the wiki.
>>> 
>>> I am therefore not sure if this patch set should be merged or if it should be updated with the new library (and how) or if git should still be left in IPFire as an addon and hence this library.
>>> 
>>> I am open to whatever decision you think is appropriate for this patch set.
>>> 
>>> Regards,
>>> Adolf.
>>> 
>>> On 22/03/2021 08:33, Adolf Belka wrote:
>>>> - Update from 1.02 to 1.04
>>>> - Update of rootfile not required
>>>> - This is a dependency of git addon package
>>>> - Changelog
>>>>    1.04    2016-10-09
>>>>     - mark this library deprecated, suggest newer Net::SMTP instead
>>>>    1.03    2015-06-20
>>>>     - $net_smtp_ssl->isa('Net::SMTP') is now true
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>>  lfs/perl-Net-SMTP-SSL | 6 +++---
>>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-Net-SMTP-SSL
>>>> index 90e8a2260..2bb00a808 100644
>>>> --- a/lfs/perl-Net-SMTP-SSL
>>>> +++ b/lfs/perl-Net-SMTP-SSL
>>>> @@ -24,7 +24,7 @@
>>>>    include Config
>>>>  -VER        = 1.02
>>>> +VER        = 1.04
>>>>    THISAPP    = Net-SMTP-SSL-$(VER)
>>>>  DL_FILE    = ${THISAPP}.tar.gz
>>>> @@ -33,7 +33,7 @@ DIR_APP    = $(DIR_SRC)/$(THISAPP)
>>>>  TARGET     = $(DIR_INFO)/$(THISAPP)
>>>>  PROG       = perl-Net-SMTP-SSL
>>>>  DEPS       =
>>>> -PAK_VER    = 2
>>>> +PAK_VER    = 3
>>>>    ###############################################################################
>>>>  # Top-level Rules
>>>> @@ -43,7 +43,7 @@ objects = $(DL_FILE)
>>>>    $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>>  -$(DL_FILE)_MD5 = e67b4d842a51b9a453aeeaeed45fb8e1
>>>> +$(DL_FILE)_MD5 = 62b49c961043898b43b041dafbc1b389
>>>>    install : $(TARGET)
>>>>  
>>> 
>>> -- 
>>> Sent from my laptop
> 
> -- 
> Sent from my laptop