From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 3/3] perl-Net-SMTP-SSL: Update to 1.04
Date: Mon, 22 Mar 2021 13:45:09 +0000
Message-ID: <339D0319-DB6D-41D3-A3B6-A7BD49BA87D4@ipfire.org>
In-Reply-To: <199c2e0a-d817-2e88-6705-de6d4e7c74d9@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4833598541012327277=="
List-Id: <development.lists.ipfire.org>

--===============4833598541012327277==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hey,

> On 22 Mar 2021, at 11:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi Michael,
>=20
> On 22/03/2021 12:19, Michael Tremer wrote:
>> Hello,
>> I merged it, because we need Git for development purposes.
>> I am writing CGI scripts on the systems and commit small changes. Copying =
files back and forth would be error-prone and waste time.
> That makes it clear what git is being used for. I am definitely following t=
he copying files back and forth approach when I am working on some of the bug=
s and have found sometimes that I have had to start all over again because of=
 errors. Makes sense to use git for managing that for the development work.

I love git. I am getting confused if I am editing files that are not part of =
a Git repository :)

>> I do not think that Git needs documentation on the wiki. There is some stu=
ff in the development section.
> Understand. It's not intended for the general user but for development work.

Yes :)

>> If we can replace this module by a newer version, that would definitely he=
lp in the future :)
> I will see if I can give it a go but that will probably need to be tested w=
ell by you and the other devs to make sure it still does what you need it to =
do.

Breaking Git is not the worst because it won=E2=80=99t affect regular users. =
Obviously we need to test, but we should be able to find out very quickly if =
it works or not.

Best,
-Michael

>=20
> Regards,
> Adolf.
>> -Michael
>>> On 22 Mar 2021, at 07:44, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>=20
>>> Hi All,
>>>=20
>>> When updating this dependency of git I saw that it was now deprecated. I =
had a look at the replacement library and while I could create it as a new ad=
don, it was not clear to me if just defining it as a dependency of git would =
make git correctly use it.
>>>=20
>>> I am also not sure why anyone would want to run git on a firewall. This a=
ddon is not listed in the wiki.
>>>=20
>>> I am therefore not sure if this patch set should be merged or if it shoul=
d be updated with the new library (and how) or if git should still be left in=
 IPFire as an addon and hence this library.
>>>=20
>>> I am open to whatever decision you think is appropriate for this patch se=
t.
>>>=20
>>> Regards,
>>> Adolf.
>>>=20
>>> On 22/03/2021 08:33, Adolf Belka wrote:
>>>> - Update from 1.02 to 1.04
>>>> - Update of rootfile not required
>>>> - This is a dependency of git addon package
>>>> - Changelog
>>>>    1.04    2016-10-09
>>>>     - mark this library deprecated, suggest newer Net::SMTP instead
>>>>    1.03    2015-06-20
>>>>     - $net_smtp_ssl->isa('Net::SMTP') is now true
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>>  lfs/perl-Net-SMTP-SSL | 6 +++---
>>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-Net-SMTP-SSL
>>>> index 90e8a2260..2bb00a808 100644
>>>> --- a/lfs/perl-Net-SMTP-SSL
>>>> +++ b/lfs/perl-Net-SMTP-SSL
>>>> @@ -24,7 +24,7 @@
>>>>    include Config
>>>>  -VER        =3D 1.02
>>>> +VER        =3D 1.04
>>>>    THISAPP    =3D Net-SMTP-SSL-$(VER)
>>>>  DL_FILE    =3D ${THISAPP}.tar.gz
>>>> @@ -33,7 +33,7 @@ DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>>>>  TARGET     =3D $(DIR_INFO)/$(THISAPP)
>>>>  PROG       =3D perl-Net-SMTP-SSL
>>>>  DEPS       =3D
>>>> -PAK_VER    =3D 2
>>>> +PAK_VER    =3D 3
>>>>    #####################################################################=
##########
>>>>  # Top-level Rules
>>>> @@ -43,7 +43,7 @@ objects =3D $(DL_FILE)
>>>>    $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>>  -$(DL_FILE)_MD5 =3D e67b4d842a51b9a453aeeaeed45fb8e1
>>>> +$(DL_FILE)_MD5 =3D 62b49c961043898b43b041dafbc1b389
>>>>    install : $(TARGET)
>>>> =20
>>>=20
>>> --=20
>>> Sent from my laptop
>=20
> --=20
> Sent from my laptop


--===============4833598541012327277==--